feat(frontend): include vitest lint rules
#5797
Draft
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 15, 2025
AntonioVentilii
added a commit
that referenced
this pull request
Apr 15, 2025
# Motivation We are going to add the vitest linter (PR #5797), but it raises quite a few issues. So, in preparation, for now we apply the rule [vitest/padding-around-all](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/padding-around-all.md) on the `lib` test folder.
AntonioVentilii
added a commit
that referenced
this pull request
Apr 15, 2025
# Motivation We are going to add the vitest linter (PR #5797), but it raises quite a few issues. So, in preparation, for now we apply the rule [vitest/padding-around-all](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/padding-around-all.md) on the `sol` test folder.
AntonioVentilii
added a commit
that referenced
this pull request
Apr 15, 2025
# Motivation We are going to add the vitest linter (PR #5797), but it raises quite a few issues. So, in preparation, for now we apply the rule [vitest/padding-around-all](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/padding-around-all.md) on the `icp` test folder.
AntonioVentilii
added a commit
that referenced
this pull request
Apr 15, 2025
# Motivation We are going to add the vitest linter (PR #5797), but it raises quite a few issues. So, in preparation, for now we apply the rule [vitest/padding-around-all](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/padding-around-all.md) on the `eth` test folder.
AntonioVentilii
added a commit
that referenced
this pull request
Apr 15, 2025
# Motivation We are going to add the vitest linter (PR #5797), but it raises quite a few issues. So, in preparation, for now we apply the rule [vitest/padding-around-all](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/padding-around-all.md) on the `btc` test folder.
This was referenced Apr 15, 2025
AntonioVentilii
added a commit
that referenced
this pull request
Apr 15, 2025
# Motivation We are going to add the vitest linter (PR #5797), but it raises quite a few issues. So, in preparation, for now we apply the rule [vitest/padding-around-all](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/padding-around-all.md) on the E2E test folder.
AntonioVentilii
added a commit
that referenced
this pull request
Apr 16, 2025
…5881) # Motivation We are going to add the vitest linter (PR #5797), but it raises quite a few issues. So, in preparation, for now we apply the rule [vitest/no-duplicate-hooks](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-duplicate-hooks.md) on the btc-wallet worker tests. We will make the test util return three callback functions: one for the `beforeEach` hook, one for the `afterEach` hook and one that contains the tests. # Changes - Create interface for the test utils. - Make `testWorker` in the `btc-wallet.worker` tests return `setup`, `teardown` and `tests` functions. - Use the functions when calling `testWorker`. # Tests Current tests work as before.
AntonioVentilii
added a commit
that referenced
this pull request
Apr 16, 2025
…ts (#5878) # Motivation We are going to add the vitest linter (PR #5797), but it raises quite a few issues. So, in preparation, for now we apply the rule [vitest/no-duplicate-hooks](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-duplicate-hooks.md) on the sol-wallet scheduler tests. We will make the test util return three callback functions: one for the `beforeEach` hook, one for the `afterEach` hook and one that contains the tests. # Changes - Create interface for the test utils. - Make `testWorker` in the `sol-wallet.scheduler` tests return `setup`, `teardown` and `tests` functions. - Use the functions when calling `testWorker`. # Tests Current tests work as before.
AntonioVentilii
added a commit
that referenced
this pull request
Apr 16, 2025
… tests (#5879) # Motivation We are going to add the vitest linter (PR #5797), but it raises quite a few issues. So, in preparation, for now we apply the rule [vitest/no-duplicate-hooks](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-duplicate-hooks.md) on the ic-wallet-balance worker tests. We will make the test util return three callback functions: one for the `beforeEach` hook, one for the `afterEach` hook and one that contains the tests. # Changes - Create interface for the test utils. - Make `initWithBalance` in the `ic-wallet-balance.worker` tests return `setup`, `teardown` and `tests` functions. - Make `initOtherScenarios` in the `ic-wallet-balance.worker` tests return `setup`, `teardown` and `tests` functions. - Use the functions when calling `initWithBalance` and `initOtherScenarios`. # Tests Current tests work as before.
AntonioVentilii
changed the title
vitest lint rules
AntonioVentilii
added a commit
that referenced
this pull request
Apr 16, 2025
…5880) # Motivation We are going to add the vitest linter (PR #5797), but it raises quite a few issues. So, in preparation, for now we apply the rule [vitest/no-duplicate-hooks](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-duplicate-hooks.md) on the ic-wallet-balance-and-transactions worker tests. We will make the test util return three callback functions: one for the `beforeEach` hook, one for the `afterEach` hook and one that contains the tests. # Changes - Create interface for the test utils. - Make all init test utils in the `ic-wallet-balance-and-transactions.worker` tests return `setup`, `teardown` and `tests` functions. - Use the functions when calling each test. # Tests Current tests work as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to start including the vitest rules provided by the library eslint-config-oisy-wallet.