Skip to content

feat(frontend): Sliding input component #5811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Apr 15, 2025

Conversation

daviddecentage
Copy link
Collaborator

@daviddecentage daviddecentage commented Apr 11, 2025

Motivation

For the upcoming token list filter PR we need to create a sliding input that opens over its parent content.

Changes

  • Added condensed variant for inputs
  • Export input value so it can be bound
  • Added SlidingInput component
  • Added SlidingInputBoundary component

Tests

Sliding input showcasing passing overflowable-content slot, responsiveness, clear and outside click functionality:

Bildschirmaufnahme_20250414_114221.mp4

Sliding input showcasing without overflowable-content slot, passing different icon, to be reused anywhere without adjusting to parent element:

Bildschirmaufnahme_20250414_114338.mp4

@daviddecentage daviddecentage marked this pull request as ready for review April 11, 2025 13:00
@daviddecentage daviddecentage requested a review from a team as a code owner April 11, 2025 13:00
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this component! Some observations:

Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks!

@AntonioVentilii AntonioVentilii enabled auto-merge (squash) April 14, 2025 16:15
@AntonioVentilii AntonioVentilii merged commit bbdb38d into main Apr 15, 2025
25 checks passed
@AntonioVentilii AntonioVentilii deleted the feat(frontend)/sliding-input branch April 15, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants