Skip to content

fix(snapline): snapline cannot show when zoomed #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HawtinZeng
Copy link

This PR have not passed the test, because of some unrelated errors.
image
And the jest systax error: jest-runner\build\index.js: Class private methods are not enabled

Copy link

changeset-bot bot commented May 15, 2025

⚠️ No Changeset found

Latest commit: c22e33c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ChangeSuger
Copy link
Collaborator

👍,感谢 PR,这边提两个修改建议:

  1. 建议修改变量命名:epsino (?) -> spsilon ( $\epsilon$ )
  2. 目前只修改了 getHorizontalSnapline 方法(水平对齐辅助线),getVerticalSnapline 方法(垂直对齐辅助线)建议也一并修改

@HawtinZeng
Copy link
Author

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants