Use enum values from enumType in DiscriminatorColumn and check DiscriminatorMap values against it #11804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtFieldsWhereDeclared`
These new issues are caused by doctrine/common 3.5.0, released 2 weeks ago.
Ignore deprecations from doctrine/common
…clared Fix fields of transient classes being considered duplicate with `reportFieldsWhereDeclared`
Nullability is not inherited from the PHP type. The change that enabled this feature was reversed in doctrine#8732.
Fix invalid enum value in array of enums
|
I'm unsure where to go from here. It seems to me tests are failing on platforms with no native enum support. |
No, the tests are failing on DBAL versions without |
We should be using quoteSingleIdentifier(), assuming we only ever pass single identifiers here. See doctrine/dbal#6590
The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
…exed-relation 11783 failure with indexed relation
Address quoteIdentifier() deprecation
Bumps [doctrine/.github](https://github.com/doctrine/.github) from 7.1.0 to 7.2.1. - [Release notes](https://github.com/doctrine/.github/releases) - [Commits](doctrine/.github@7.1.0...7.2.1) --- updated-dependencies: - dependency-name: doctrine/.github dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ions/2.20.x/doctrine/dot-github-7.2.1 Bump doctrine/.github from 7.1.0 to 7.2.1
[DDC-551] fix, add filter support in oneToOne relation 2.20.x
…ctor This fixes a bug that arises when using Pagination and an entity relation is mapped with fetch-mode EAGER but setFetchMode LAZY (or anything that is not EAGER) has been used on the query. If the query use WITH condition, an exception is incorrectly raised (Associations with fetch-mode=EAGER may not be using WITH conditions). The class LimitSubqueryOutputWalker clones the query, but not its parameters and hints, so the generated subquery does not know that fetch-mode has been overridden. Fixes doctrine#11741
Clone query hints and parameters in `LimitSubqueryOutputWalker` constructor
Fix DQL example with composite key
Fix URL's in xml-mapping.rst
…eats Add more detailed caveats for using the Collection filtering API
replace Index::overrules() with custom checks
no longer use Table::columnsAreIndexed()
do not use deprecated foreign key constraint features
use the platform to quote table names
[doctrine#6823] pass unquoted identifier folding to AbstractPlatform
* doc: fix setFileExtension() xml mapping documentation * Update docs/en/reference/xml-mapping.rst Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr> --------- Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
The old proxy implementation of doctrine/common was triggered by public methods rather than access to properties (making public properties unsupported in entities), so tests could use public instance properties to track the state of postLoad lifecycle callbacks without triggering the proxy initialization when reading that state (which then changes the state of triggering the postLoad callback). As the new proxy implementation hooks into properties instead, the tests now use a static method (ensuring it is reset properly before loading the instance for which we care about the tracking) instead of an instance property.
do not use deprecated primary key constraint features
do not use deprecated index features
disable detecting modified indexes with DBAL 4.3
prefer primary key constraints over Index::isPrimary()
PostLoad listeners might initialize values for transient properties, so the proxy should not skip initialization when using transient properties. Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>
Fix the initialization of lazy-ghost proxies with postLoad listeners
Merge 2.20.x up into 3.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #11794.
Currently the values of enumType in DiscriminatorColumn are ignored which results in an error when generating a migration:
Fixed by populating values from the enum and also prevent invalid entries in DiscriminatorMap.