[resolvers][federation] Fix fields or types being wrong generated when marked with @external #10287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7949e63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eddeee888
commented
Feb 10, 2025
Comment on lines
+442
to
+493
| // A ObjectTypeDefinitionNode's directive looks like `{ kind: 'Directive', name: 'external', arguments: [] }` | ||
| // However, other directives looks like `{ kind: 'Directive', name: { kind: 'Name', value: 'external' }, arguments: [] }` | ||
| // Therefore, we need to check for both `d.name.value` and d.name | ||
| return d.name.value === name || (d.name as unknown as string) === name; |
There was a problem hiding this comment.
This is an observation from running unit tests. I'm not sure right now if this is a bug in graphql lib or we did something in our plugins that caused this. Either way, I'm putting this in first to unblock this PR
eddeee888
force-pushed
the
fix-external-signature
branch
from
ddfa8e3 to
fbab7d6
Compare
Base automatically changed from
fix-is-typeof-when-needed
to
federation-fixes
February 19, 2025 09:42
eddeee888
force-pushed
the
federation-fixes
branch
from
b0b7e86 to
0b0c9bf
Compare
eddeee888
force-pushed
the
federation-fixes
branch
from
1a64f6d to
6a2bca7
Compare
eddeee888
force-pushed
the
fix-external-signature
branch
from
fbab7d6 to
7949e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a field or type is marked with
@external, the resolver should not be generated (unless part of@provides). This PR takes care of the following scenarios:@external, do not generate it@external, the object type's resolvers signature must still useParentTypefor its first param@external, do not generate the type@external, do not generate the type@external, but the object type itself is marked with@external, what happens?@providesin play?Related #10206
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration