-
-
Notifications
You must be signed in to change notification settings - Fork 992
Reduce async overhead #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Reduce async overhead #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c38f6de
to
493e2a7
Compare
493e2a7
to
72602a1
Compare
b3a7a80
to
95ae533
Compare
Updated BenchmarkType and InProcess toolchains to use AwaitHelper.
…lchain. Added support for `ValueTask` benchmark in InProcess.NoEmit. Added tests.
…nt in-process deadlocks.
Properly force unroll factor to 1. Wait for Setup/Cleanup actions in engine.
TODO: debug cause of crash
Fixed some EmitSameIL tests.
6d332d9
to
f07c0a1
Compare
f07c0a1
to
bdedcf9
Compare
Since the request to add is gigantic and it still not reviewed, can you break it down into smaller ones? For example, async InProcess.GlobalSetup fix, thank you. |
@YegorStepanov #1941 is a smaller PR that has the actual fixes. This PR is larger because it required a refactor to reduce the async overhead. |
Replaced by #2111. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1941 (fixes #1595 and fixes #1738)
Refactored delegates to reduce async measurement overhead (sync measurements are the same).
Also added IterationSetup/Cleanup async support.
Master:
This PR:
If you want, we can close #1941 in favor of this, but there are more changes here which should be reviewed. Or #1941 can be merged before this, which is also fine.
Merging this PR will also make it easier/possible to add async engine support in the future.
cc @AndreyAkinshin @adamsitnik @stephentoub