Add host.docker.internal and host.containers.internal to the dev cert SAN #61265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new SAN for dev cert + json output for the tool
dotnet-issue-labeler
bot
added
the
area-commandlinetools
|
Looks good so far! |
3 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR updates the certificate generation functionality to include "host.docker.internal" and "host.containers.internal" in the SAN, bumps the certificate version to 3, and adds a new command for JSON output of certificate information.
- Introduces the new --check-json-output option and its logic
- Refactors certificate version handling by separating generated version and minimum acceptable version
- Updates tests and adjusts access modifiers in platform-specific certificate managers
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Tools/dotnet-dev-certs/src/Program.cs | Adds new JSON output option and updates certificate filtering on OSX |
| src/Tools/FirstRunCertGenerator/test/CertificateManagerTests.cs | Updates tests to use the new MinimumAspNetHttpsCertificateVersion property |
| src/Shared/CertificateGeneration/WindowsCertificateManager.cs, UnixCertificateManager.cs, MacOSCertificateManager.cs | Adjusts access modifiers for the IsExportable method |
| src/Shared/CertificateGeneration/CertificateManager.cs | Bumps certificate version constants, adds new SAN entries, and introduces the MinimumAspNetHttpsCertificateVersion property |
3 tasks
adityamandaleeka
approved these changes
Apr 16, 2025
|
Test failure is real. |
| @@ -110,6 +114,10 @@ public static int Main(string[] args) | |||
| "Display warnings and errors only.", | |||
| CommandOptionType.NoValue); | |||
|
|
|||
| var checkJsonOutput = c.Option("--check-trust-machine-readable", | |||
There was a problem hiding this comment.
@DamianEdwards is this good? Last chance to change it 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add host.docker.internal and host.containers.internal to the dev cert SAN
Add necessary SAN for dev container scenario and add an easy to parse output to the dev-certs command.
Description
host.docker.internalandhost.containers.internalto the dev cert SAN.3--check --trustbut with json output:--check-json-outputThe notion of minimum version is important if/when we backport this feature into dotnet 8 and 9: the runtime in 8 or 9 should be able to run perfectly fine without the new SAN in the cert.
Example of output for a v2 certificate (generated with .NET 9):
Example of output for a v3 certificate:
Fixes #61155