Disable PingTest.CancelSendPingAsync on OSX #114783
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables the CancelSendPingAsync test on OSX to work around an active issue (#114782) while also updating the formatting of a ProcessStartInfo initializer.
- Added a conditional check in CancelSendPingAsync to throw a SkipTestException on OSX when useIPAddress is true and useCancellationToken is false.
- Reformatted the ProcessStartInfo initializer for consistency.
rzikm
commented
Apr 22, 2025
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 22, 2025
ManickaP
approved these changes
Apr 22, 2025
ManickaP
reviewed
Apr 22, 2025
| @@ -694,6 +694,11 @@ public async Task SendPingAsyncWithAlreadyCanceledToken(bool useIPAddress) | |||
| [OuterLoop] // Depends on external host and assumption that successful ping takes long enough for cancellation to go through first | |||
| public async Task CancelSendPingAsync(bool useIPAddress, bool useCancellationToken) | |||
| { | |||
| if (PlatformDetection.IsOSX && useIPAddress && !useCancellationToken) | |||
There was a problem hiding this comment.
In the SkipTestException message
liveans
approved these changes
Apr 22, 2025
|
/ba-g test failures are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #114782