Skip to content

Improve error message when running on outdated Windows OS with incomplete CET support #114839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Apr 20, 2025

Fixes #110000

@Copilot Copilot AI review requested due to automatic review settings April 20, 2025 04:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the error messaging when running on outdated Windows OS versions that have incomplete CET support. It replaces an assertion with a runtime fatal error that provides a clear, user‐facing message.

  • Replaced the assertion regarding shadow stacks with an explicit error check.
  • Introduced a detailed error message prompting users to install available Windows updates.
Comments suppressed due to low confidence (1)

src/coreclr/vm/threads.cpp:7709

  • The updated error message clearly informs users about incomplete CET support on Windows. Ensure that the message format and localization (if applicable) remain consistent with similar error messages elsewhere in the codebase, and consider referencing documentation for further guidance.
if (AreShadowStacksEnabled() && !UseSpecialUserModeApc())

Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas merged commit 4144fda into dotnet:main Apr 21, 2025
96 checks passed
@jkotas jkotas deleted the issue-110000 branch April 21, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet run error Assert failure(PID 28188 [0x00006e1c], Thread: 26664 [0x6828]) in .net 9
2 participants