Update 3x pixel-firing logic to more closely match broken site prompt #5862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
|
@laghee, If I understand correctly, the logic to reset refresh count is not affected (reset once 3x or more refreshes), however, if the user refreshes 4x, we'd only send the 2x once. Not sure if that's expected / what iOS does in that case |
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
| } | ||
| pixel.fire(AppPixelName.RELOAD_THREE_TIMES_WITHIN_20_SECONDS) | ||
| Timber.d("KateTest--> should show bc 3 refreshes") | ||
| site?.let { brokenSitePrompt.shouldShowBrokenSitePrompt(it.url) } ?: false |
There was a problem hiding this comment.
I guess null site here is an edge case here, so probably fine if pixel and prompt fall out of sync
| } | ||
|
|
||
| val dismissStreakResetDays = brokenSiteReportRepository.getDismissStreakResetDays().toLong() | ||
| val dismissalCount = brokenSiteReportRepository.getDismissalCountBetween( | ||
| currentTimestamp.minusDays(dismissStreakResetDays), | ||
| currentTimestamp.minusMinutes(dismissStreakResetDays), |
There was a problem hiding this comment.
Careful to revert this later
|
|
||
| return dismissalCount < brokenSiteReportRepository.getMaxDismissStreak() | ||
| } | ||
|
|
||
| override suspend fun ctaShown() { | ||
| val currentTimestamp = currentTimeProvider.localDateTimeNow() | ||
| val newNextShownDate = currentTimestamp.plusDays(brokenSiteReportRepository.getCoolDownDays()) | ||
| val newNextShownDate = currentTimestamp.plusSeconds(brokenSiteReportRepository.getCoolDownDays()) |
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/refreshpixels/RefreshPixelSender.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/duckduckgo/app/browser/refreshpixels/RefreshPixelSenderTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/com/duckduckgo/app/browser/refreshpixels/RefreshPixelSenderTest.kt
Show resolved
Hide resolved
app/src/test/java/com/duckduckgo/app/browser/refreshpixels/RefreshPixelSenderTest.kt
Show resolved
Hide resolved
...n-site-impl/src/main/java/com/duckduckgo/brokensite/impl/BrokenSiteRefreshesInMemoryStore.kt
Outdated
Show resolved
Hide resolved
.../broken-site-impl/src/main/java/com/duckduckgo/brokensite/impl/BrokenSiteReportRepository.kt
Outdated
Show resolved
Hide resolved
laghee
changed the title
# Conflicts: # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt
laghee
force-pushed
the
kate/update-refresh-pixel-firing
branch
from
6c44673 to
1a11483
Compare
...n-site-impl/src/main/java/com/duckduckgo/brokensite/impl/BrokenSiteRefreshesInMemoryStore.kt
Outdated
Show resolved
Hide resolved
| refreshPixelSender.onRefreshPatternDetected(detectedRefreshPatterns) | ||
|
|
||
| return if (3 in detectedRefreshPatterns && | ||
| return if (RefreshPattern.THRICE_IN_20_SECONDS in detectedRefreshPatterns && | ||
| brokenSitePrompt.shouldShowBrokenSitePrompt(nonNullSite.url) |
There was a problem hiding this comment.
I'd send refresh patterns here to encapsulate all the logic in shouldShowBrokenSitePrompt
|
@laghee, the current implementation behaves like a sliding window. If you refresh 4 times in 20 seconds, 3x pixel is fired twice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209712075249435/f
Description
We decided in https://app.asana.com/0/1205142657210376/1209698956036733 that we would prefer the separate 3x pixel to fire for distinct 3-refresh groupings in the chosen time period as opposed to 3 refreshes that fall into a sliding window of time to more closely match the breakage prompt trigger.
Steps to test this PR
NB: Logic is currently patched to delay 7 seconds between accepted prompts & stop prompting with 3+ dismissals within the past 30 min.
Feature 1