Refactor find in page state #5926
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
LukasPaczos
force-pushed
the
feature/lukasz-p/update-find-in-page-design
branch
from
d5b432d to
a5a96b2
Compare
Base automatically changed from
feature/lukasz-p/update-find-in-page-design
to
develop
April 17, 2025 19:37
LukasPaczos
added a commit
that referenced
this pull request
Apr 17, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/1208671518894266/task/1209874980847232 ### Description The "find in page" state is currently fully managed by `BrowserTabViewModel`. This PR makes the omnibar aware of the visibility portion of that state - just enough for it to react and pass it down to its children. Functionally, there’s no change for the production omnibar. But in the experimental omnibar - where the "find in page" UI is moved inside the card - we can now detect when it’s shown and hide other content accordingly. This lets us reuse the omnibar card’s existing design and animations. This PR keeps the changes minimal, focused on adapting "find in page" for the experimental omnibar. As a follow up, in #5926, I'm attempting to migrate the whole of "find in page" state management out of `BrowserTabViewModel` and into the omnibar, along with further cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip