Skip to content

Android: FAB button looks different on different OS versions #5948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

anikiki
Copy link
Contributor

@anikiki anikiki commented Apr 22, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210045609366338?focus=true

Description

Added a circular style to the close button in onboarding dialogs by applying the Widget.DuckDuckGo.FloatingActionButton.Circular style to the FAB in both bubble and in-context DAX dialog layouts. Created a new style in widgets.xml that uses the Material Components circular shape appearance overlay.

Steps to test this PR

Verify close button appearance

  • Open the onboarding bubble DAX dialog and verify the close button has a circular shape
  • Open the in-context DAX dialog and verify the close button has a circular shape

UI changes

Before (context dialog) After (context dialog) After (in-context dialog)
Screenshot 2025-04-22 Screenshot_20250422_185631 Screenshot_20250422_185648

Copy link
Contributor Author

anikiki commented Apr 22, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@anikiki anikiki marked this pull request as ready for review April 22, 2025 17:41
@anikiki anikiki changed the title Added style for circular FAB. Updated style for the dismiss button in onboarding. Android: FAB button looks different on different OS versions Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants