Redesign Message Dialog #2934
Redesign Message Dialog #2934
Conversation
|
As the discussion on the bug reveals, there is no obvious consensus to find between aligned left vs centered; however, all OSs recommend to get the width fit the content (ie no extra space), so I think for a first iteration, we should focus on just saving the extra space (changing the min width to 0 or DEFAULT), and consider whether to center or not later; maybe if all OSs align on the same recommendation some day. |
SougandhS
force-pushed
the
SaveBoxAlignment
branch
from
cd6224c to
f549998
Compare
|
Updated one 
|
|
I'm seeing an issue with the given patch: the MessageDialog now tends to become too large: Before After |
SougandhS
force-pushed
the
SaveBoxAlignment
branch
from
f549998 to
0100808
Compare
Made minor adjustment for these cases |
Removed unnecessary spacing in the message dialog to improve visual alignment and create a more compact, cleaner layout. Fixes : eclipse-platform#2929
SougandhS
force-pushed
the
SaveBoxAlignment
branch
from
0100808 to
1db3a95
Compare
| @@ -328,7 +328,6 @@ protected Control createDialogArea(Composite parent) { | |||
| layout.marginWidth = 0; | |||
| composite.setLayout(layout); | |||
| GridData data = new GridData(GridData.FILL_BOTH); | |||
| data.horizontalSpan = 2; | |||
There was a problem hiding this comment.
I thought there was previously already feedback about this change affecting all subclasses. There are a great many so this seems not a good idea at all.
| @@ -100,13 +100,14 @@ protected Control createMessageArea(Composite composite) { | |||
| if (message != null) { | |||
| messageLabel = new Label(composite, getMessageLabelStyle()); | |||
| messageLabel.setText(message); | |||
| int minWidthHint = convertHorizontalDLUsToPixels(IDialogConstants.MINIMUM_MESSAGE_AREA_WIDTH - 50); | |||
There was a problem hiding this comment.
It's odd to compute this in advance and then only use it conditionally later.
| convertHorizontalDLUsToPixels(IDialogConstants.MINIMUM_MESSAGE_AREA_WIDTH), | ||
| SWT.DEFAULT).applyTo(messageLabel); | ||
| .indent(5, 0) | ||
| .hint(message.length() > 40 ? minWidthHint : SWT.DEFAULT, SWT.DEFAULT) |
There was a problem hiding this comment.
The number 40 is quite magic. I wonder how things like font size and scaling might affect what this number should be?
Removes unwanted space and aligns message content & buttons to center
Before
After
Fixes : #2929