-
Notifications
You must be signed in to change notification settings - Fork 128
Mark IPlatformConfiguration/Factory for removal #1651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This pull request changes some projects for the first time in this development cycle.
An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patch
Further information are available in Common Build Issues - Missing version increments. |
LGTM |
Test Results 1 758 files ±0 1 758 suites ±0 1h 24m 43s ⏱️ - 6m 34s For more details on these failures, see this check. Results for commit 7b59656. ± Comparison against base commit 86aa0ac. ♻️ This comment has been updated with latest results. |
d387886
to
387dc8b
Compare
@laeubi looks like this adds additional warnings (for example The type IPlatformConfiguration.IFeatureEntry has been deprecated and marked for removal) to the build and fails the quality gate. Can you have to look? IIRC mark for removal should be done in M1 |
@vogella this is JDT bug: eclipse-jdt/eclipse.jdt.core#3402 so we can not really do much than to accept the new warnings and hope for the best :-) |
In this case I suggest to merge (I assume this will update also the quality gate and future PR will use the new warning number created by this JDT bug ). |
387dc8b
to
e2aa858
Compare
Can this be merged? |
e2aa858
to
e4a55c1
Compare
These interfaces are currently only used by ConfiguratorUtils that is already marked for removal on 2024-03
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please extend the deprecation note a bit.
We discussed this topic a while ago at the PMC, but I haven't had the time to send the note around yet.
@@ -36,7 +36,7 @@ | |||
* @deprecated The org.eclipse.update component has been replaced by Equinox p2. | |||
* This API will be deleted in a future release. See bug 311590 for details. | |||
*/ | |||
@Deprecated | |||
@Deprecated(forRemoval = true, since = "2025-03") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Deprecated(forRemoval = true, since = "2025-03") | |
@Deprecated(forRemoval = true, since = "2025-03 (removal in 2027-03 or later)") |
@@ -27,7 +27,7 @@ | |||
* @deprecated The org.eclipse.update component has been replaced by Equinox p2. | |||
* This API will be deleted in a future release. See bug 311590 for details. | |||
*/ | |||
@Deprecated | |||
@Deprecated(forRemoval = true, since = "2025-03") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Deprecated(forRemoval = true, since = "2025-03") | |
@Deprecated(forRemoval = true, since = "2025-03 (removal in 2027-03 or later)") |
It's 2025-06 now... |
I hereby grant anyone interested in this change to apply whatever seems suitable... I just wanted to make it for removal now its pending for month due to different things and the build constantly fails some validations that I'm not sure I want to really invest more time here. |
These interfaces are currently only used by ConfiguratorUtils that is already marked for removal on 2024-03
See