Skip to content

Mark IPlatformConfiguration/Factory for removal #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Dec 15, 2024

These interfaces are currently only used by ConfiguratorUtils that is already marked for removal on 2024-03

See

@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Dec 15, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

update/org.eclipse.update.configurator/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From b0f4fa4a2f4e3998ce976024320fc5f3b14d1b03 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sat, 3 May 2025 04:53:03 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
index 5f045c7318..f1a5deb034 100644
--- a/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
+++ b/update/org.eclipse.update.configurator/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.update.configurator; singleton:=true
-Bundle-Version: 3.5.600.qualifier
+Bundle-Version: 3.5.700.qualifier
 Bundle-Activator: org.eclipse.update.internal.configurator.ConfigurationActivator
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@vogella
Copy link
Contributor

vogella commented Dec 15, 2024

LGTM

Copy link
Contributor

github-actions bot commented Dec 15, 2024

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 24m 43s ⏱️ - 6m 34s
 4 173 tests ±0   4 149 ✅  - 1   23 💤 ±0  1 ❌ +1 
13 119 runs  ±0  12 949 ✅  - 3  167 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 7b59656. ± Comparison against base commit 86aa0ac.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Contributor

vogella commented Dec 18, 2024

@laeubi looks like this adds additional warnings (for example The type IPlatformConfiguration.IFeatureEntry has been deprecated and marked for removal) to the build and fails the quality gate. Can you have to look? IIRC mark for removal should be done in M1

@laeubi
Copy link
Contributor Author

laeubi commented Dec 18, 2024

@vogella this is JDT bug:

eclipse-jdt/eclipse.jdt.core#3402

so we can not really do much than to accept the new warnings and hope for the best :-)

@vogella
Copy link
Contributor

vogella commented Dec 18, 2024

@vogella this is JDT bug:

eclipse-jdt/eclipse.jdt.core#3402

so we can not really do much than to accept the new warnings and hope for the best :-)

In this case I suggest to merge

(I assume this will update also the quality gate and future PR will use the new warning number created by this JDT bug ).

@vogella
Copy link
Contributor

vogella commented Jan 13, 2025

Can this be merged?

These interfaces are currently only used by ConfiguratorUtils that is
already marked for removal on 2024-03
@laeubi laeubi force-pushed the mark_for_removal branch from e4a55c1 to 34516ab Compare May 3, 2025 04:48
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please extend the deprecation note a bit.
We discussed this topic a while ago at the PMC, but I haven't had the time to send the note around yet.

@@ -36,7 +36,7 @@
* @deprecated The org.eclipse.update component has been replaced by Equinox p2.
* This API will be deleted in a future release. See bug 311590 for details.
*/
@Deprecated
@Deprecated(forRemoval = true, since = "2025-03")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Deprecated(forRemoval = true, since = "2025-03")
@Deprecated(forRemoval = true, since = "2025-03 (removal in 2027-03 or later)")

@@ -27,7 +27,7 @@
* @deprecated The org.eclipse.update component has been replaced by Equinox p2.
* This API will be deleted in a future release. See bug 311590 for details.
*/
@Deprecated
@Deprecated(forRemoval = true, since = "2025-03")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Deprecated(forRemoval = true, since = "2025-03")
@Deprecated(forRemoval = true, since = "2025-03 (removal in 2027-03 or later)")

@merks
Copy link
Contributor

merks commented May 3, 2025

It's 2025-06 now...

@laeubi
Copy link
Contributor Author

laeubi commented May 3, 2025

I hereby grant anyone interested in this change to apply whatever seems suitable... I just wanted to make it for removal now its pending for month due to different things and the build constantly fails some validations that I'm not sure I want to really invest more time here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants