Cleanup missing use of StandardCharsets #125424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random annoyance that I figured, I'd just fix globally: We can do a bit of a cleaner job when doing byte <-> string conversion here and there.
original-brownbear
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
approved these changes
Mar 21, 2025
original-brownbear
added
the
auto-backport
|
Thanks Ryan! Sure thing on the forbidden APIs! I'll open a follow-up for that, just tried it and there's some nuance there. PR incoming :) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 21, 2025
Random annoyance that I figured, I'd just fix globally: We can do a bit of a cleaner job when doing byte <-> string conversion here and there.
💚 Backport successful
|
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
Random annoyance that I figured, I'd just fix globally: We can do a bit of a cleaner job when doing byte <-> string conversion here and there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random annoyance that I figured, I'd just fix globally: We can do a bit of a cleaner job when doing byte <-> string conversion here and there.