Skip to content

Update bulk scorer cancellation interval to match BooleanScorer window size #127034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benwtrent
Copy link
Member

BooleanScorer's window has been updated, lets increase our initial cancellation check to match.

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Apr 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense lgtm

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 17, 2025
@elasticsearchmachine elasticsearchmachine merged commit 4fcd4ad into elastic:main Apr 21, 2025
17 checks passed
@benwtrent benwtrent deleted the non-issue/update-exitable-check branch April 21, 2025 17:27
cbuescher added a commit to cbuescher/elasticsearch that referenced this pull request Apr 25, 2025
After CancellableBulkScorer#INITIAL_INTERVAL was increased from 2028 to
4096 in elastic#127034 this test needs updating to the new value.

Closes elastic#127156
cbuescher added a commit that referenced this pull request Apr 25, 2025
After CancellableBulkScorer#INITIAL_INTERVAL was increased from 2028 to
4096 in #127034 this test needs updating to the new value.

Closes #127156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants