Add a new highlighter based on lucene's match highlighter #92068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>feature
:Search Relevance/Highlighting
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @romseygeek, I've created a changelog YAML for you. |
romseygeek
commented
Dec 2, 2022
| @@ -106,7 +107,7 @@ | |||
|
|
|||
| public class HighlighterSearchIT extends ESIntegTestCase { | |||
| // TODO as we move analyzers out of the core we need to move some of these into HighlighterWithAnalyzersTests | |||
| private static final String[] ALL_TYPES = new String[] { "plain", "fvh", "unified" }; | |||
| private static final String[] ALL_TYPES = new String[] { "plain", "fvh", "unified", "matches" }; | |||
|
|
|||
There was a problem hiding this comment.
At some point we should rewrite at least some of this as an abstract highlighter test case which each highlighter implementation can then test itself against.
| @@ -3508,6 +3509,9 @@ public void testWithNestedQuery() throws Exception { | |||
| // but we highlight the root text field since nested documents cannot be highlighted with postings nor term vectors | |||
| // directly. | |||
| for (String type : ALL_TYPES) { | |||
| if (Objects.equals("matches", type)) { | |||
| continue; // matches highlighter doesn't support nested fields | |||
| } | |||
|
Note that the majority of the lines in this PR are copies of Apache Lucene classes that will be removed after the next lucene release, as they contain usability fixes I discovered while working on this project. |
…r' into highlight/matches-highlighter
javanna
added
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is considerably simpler and more accurate than our existing highlighters,
and should cover the vast majority of required functionality.
Still to do:
I'd like to go through the
:Search/Highlightinglabel and see if any of the reported bugs there become easier to fix with this implementation.