-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Feature/allow numeric field exact searches to use docvalues #99801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
piergm
wants to merge
18
commits into
elastic:main
Choose a base branch
from
piergm:feature/Allow-numeric-field-exact-searches-to-use-docvalues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/allow numeric field exact searches to use docvalues #99801
piergm
wants to merge
18
commits into
elastic:main
from
piergm:feature/Allow-numeric-field-exact-searches-to-use-docvalues
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In UnsignedLongFieldMapper we allow the use of docValues in order to improve performances in the case where the query is combined with more restrictive filters
…arches-to-use-docvalues
…arches-to-use-docvalues
…arches-to-use-docvalues
…arches-to-use-docvalues
…arches-to-use-docvalues
…arches-to-use-docvalues
Hi @piergm, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>enhancement
:Search Foundations/Mapping
Index mappings, including merging and defining field types
Team:Search
Meta label for search team
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BKD-tree-backed field types (NumberFieldMapper and UnsignedLongFieldMapper) use index structures optimised for range querying therefore don't execute exact match queries very efficiently.
This can lead to slow queries on the id field since using a numeric field for IDs is a common anti-pattern in elasticsearch, as ids created by other databases are often numeric in form.
We want to allow numeric fields to use IndexOrDocValuesQuery in order to improve performance in the case where a numeric id field is combined with more restrictive filters.