Skip to content

add notes for tooling 6th May #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions st-embroider/2024/2025-05-06.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
# 2025-05-06

Note Taker: Chris Manson
Time Keeper: Chris Manson

## Attendees

Add yourself to the list if you attend and check the box!

- [x] Ed Faulkner (EF)
- [x] Chris Manson (CM)
- [x] Alex (A)
- [x] Preston Sego (PS)
- [x] Simon Ihmig (SI)
- [ ] Katie Gengler (KG)
- [ ] Peter Meehan (PM)
- [ ] Krystan HuffMenne (KH)
- [ ] Peter Wagenet (PW)
- [ ] James Davis (JD)

## Topics

### Project planning

- dicsussions around the project planning board
- all blueprint addons need to be v2
- we are ready to fix ember-auto-import issues
- we can just remove it and work through the breakages
-

### Review https://github.com/embroider-build/embroider/pull/2466 <ef4>

- (deep dive into the proposed fix)
- found a better solution
- commented on the PR

### Macros unintentional breaking change <ef4>

- (discussed to figure out how fix this)
- https://github.com/embroider-build/embroider/pull/2439 is a good CI failing
- EF: I've added a todo to fix this

### Review https://github.com/embroider-build/embroider/pull/2464 <@NullVoxPopuli>

- approved
- github having issues, waiting for CI to pass

### template-tag-codemod can’t find helpers from @ember/string <@mansona>

- ember string never provided any helpers
- this is likely an issue with some other addon exporting the helper
- to debug: step into the capitalize helper using `{{debugger}}` in the hbs and see where the file is actually coming from
- (discussion about custom resolver not allowing you to have named imports)
- agreement: we can optionally return an object with the named import that we want to support

<5 min> Review https://github.com/embroider-build/embroider/issues/2461 <ef4>
<10 min> Review remaining work for v2 addon blueprint to be default - including blueprints <ef4>
1 change: 0 additions & 1 deletion st-embroider/template.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Add yourself to the list if you attend and check the box!

- [ ] Ed Faulkner (EF)
- [ ] Chris Manson (CM)
- [ ] Aaron Chambers (AC)
- [ ] Alex (A)
- [ ] Preston Sego (PS)
- [ ] Simon Ihmig (SI)
Expand Down