Correct example value type for terminalTotalDifficulty
#648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fix the example value type of
terminalTotalDifficulty
in theengine_exchangeTransitionConfigurationV1
definition .According to the schemas in
schemas/uint256
,terminalTotalDifficulty
should be auint256
, represented as a hex string with0x
prefix.However, the current example value of
terminalTotalDifficulty
is the numeric0
. This PR updates the example value from0
to0x0
.If we use the existing example value, the request will fail in geth due to a type mismatch.
By changing the format of the value to a hex string, geth can successfully parse the parameter.
Reproduce
Simply changing
"terminalTotalDifficulty": 0
leads to the aforementioned error.