fix(blog): added some clarification around dates in blog post #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bjohansebas
approved these changes
Apr 1, 2025
ctcpip
reviewed
Apr 1, 2025
ctcpip
reviewed
Apr 1, 2025
ctcpip
reviewed
Apr 1, 2025
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
wesleytodd
added a commit
to expressjs/discussions
that referenced
this pull request
Apr 1, 2025
ctcpip
approved these changes
Apr 1, 2025
rxmarbles
approved these changes
Apr 1, 2025
Phillip9587
approved these changes
Apr 1, 2025
ctcpip
added a commit
to expressjs/discussions
that referenced
this pull request
Apr 18, 2025
* feat(ADR): LTS Strategy * Update docs/adr/lts-strategy.md Co-authored-by: Zbyszek Tenerowicz <naugtur@gmail.com> * Update docs/adr/lts-strategy.md Co-authored-by: Zbyszek Tenerowicz <naugtur@gmail.com> * fix: suggestions * fix: updated dates from discussion expressjs/expressjs.com#1859 (comment) * fix: review edits * fix: formatting * Update docs/adr/lts-strategy.md Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com> --------- Co-authored-by: Zbyszek Tenerowicz <naugtur@gmail.com> Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't get to these after our meeting yesterday, but we agreed to soften the language around the dates here and then work to get consensus in the LTS ADR. We can circle back and update this as necessary, but this at least addresses the fact I incorrectly had concrete dates listed.