Skip to content
This repository was archived by the owner on Apr 28, 2023. It is now read-only.

[DO NOT MERGE] Repro maybe uninitialized variable warning triggerring error appearing with TC_CHECK #504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] Repro maybe uninitialized variable warning triggerring error appearing with TC_CHECK #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tc/core/mapping_options-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ MappingOptionsView& MappingOptionsView::scheduleFusionStrategy(

MappingOptionsView& MappingOptionsView::scheduleFusionStrategy(
const std::string& str) {
FusionStrategy fs(FusionStrategy::Max);
FusionStrategy fs;
bool couldParse = FusionStrategy_Parse(str, &fs);
TC_CHECK(couldParse) << "unknown FusionStrategy " << str;
return scheduleFusionStrategy(fs);
Expand All @@ -176,7 +176,7 @@ MappingOptionsView& MappingOptionsView::outerScheduleFusionStrategy(

MappingOptionsView& MappingOptionsView::outerScheduleFusionStrategy(
const std::string& str) {
FusionStrategy fs(FusionStrategy::Max);
FusionStrategy fs;
bool couldParse = FusionStrategy_Parse(str, &fs);
TC_CHECK(couldParse) << "unknown FusionStrategy " << str;
return outerScheduleFusionStrategy(fs);
Expand All @@ -200,7 +200,7 @@ MappingOptionsView& MappingOptionsView::intraTileScheduleFusionStrategy(

MappingOptionsView& MappingOptionsView::intraTileScheduleFusionStrategy(
const std::string& str) {
FusionStrategy fs(FusionStrategy::Max);
FusionStrategy fs;
bool couldParse = FusionStrategy_Parse(str, &fs);
TC_CHECK(couldParse) << "unknown FusionStrategy " << str;
return intraTileScheduleFusionStrategy(fs);
Expand Down
4 changes: 2 additions & 2 deletions test/isl_cli_strategy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ namespace tc {
// (at a minimum: tile, mapToThreads and mapToBlocks)
// 3. call makeCliStrategy with the overridden options
tc::CudaMappingOptions makeBaseCliStrategy() {
tc::FusionStrategy fs(FusionStrategy::Max);
tc::FusionStrategy fs;
TC_CHECK(tc::FusionStrategy_Parse(DEFAULT_FUSION_STRATEGY, &fs));
CudaMappingOptions options =
CudaMappingOptions::makeNaiveMappingOptions()
Expand All @@ -105,7 +105,7 @@ tc::CudaMappingOptions makeBaseCliStrategy() {

tc::CudaMappingOptions makeCliStrategy(tc::CudaMappingOptions options) {
if (FLAGS_fusion_strategy != std::string(DEFAULT_FUSION_STRATEGY)) {
tc::FusionStrategy fs(FusionStrategy::Max);
tc::FusionStrategy fs;
if (tc::FusionStrategy_Parse(FLAGS_fusion_strategy, &fs)) {
options.scheduleFusionStrategy(fs);
} else {
Expand Down