Skip to content

more general build_lib script #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

calad0i
Copy link
Contributor

@calad0i calad0i commented May 5, 2025

Description

$OSTYPE is not a reliable source for determining the platform. On OpenSUSE 20250503, bash returns "linux" instead of "linux-gnu" and the script failed without -fPIC.

The updated script checks if -fno-gnu-unique is supported, and appends it if so.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

Triggers on specific platforms.

@vloncar
Copy link
Contributor

vloncar commented May 9, 2025

Instead of replacing "$OSTYPE" == "linux-gnu" with "$OSTYPE" == "linux"* (a few characters change) the suggestion is to invoke the compiler to do nothing just to see if it will fail and if it doesn't then add a cflag... bit of an overkill, no? 😄

@jmitrevs
Copy link
Contributor

jmitrevs commented May 9, 2025

As an aside, should we move up from C++11? Vitis HLS I think uses C++14, Intel uses C++17. Probably makes little difference, though.

@vloncar
Copy link
Contributor

vloncar commented May 9, 2025

@jmitrevs Only if we split the build script over vivado/vitis (vivado compiler will say c++14 doesn't exist)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants