Skip to content

forward metadata #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: custom/brainsmith
Choose a base branch
from
Draft

forward metadata #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718d84c
forward metadata
May 7, 2025
7bff09f
forward metadata from gemm_to_matmul step
May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/qonnx/transformation/extract_quant_scale_zeropt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ def apply(self, model: ModelWrapper):
)
graph.value_info.append(inp_scaled)
inp_scale_node = helper.make_node("Div", [running_input, scale_nm], [inp_scaled_nm])
if hasattr(node, "metadata_props"):
inp_scale_node.metadata_props.extend(node.metadata_props)
graph.node.append(inp_scale_node)
# create new Mul node
# remove scale from Quant node
Expand All @@ -87,6 +89,8 @@ def apply(self, model: ModelWrapper):
)
graph.value_info.append(inp_zeropt)
inp_zeropt_node = helper.make_node("Add", [running_input, zeropt_nm], [inp_zeropt_nm])
if hasattr(node, "metadata_props"):
inp_zeropt_node.metadata_props.extend(node.metadata_props)
graph.node.append(inp_zeropt_node)
# remove zeropt from Quant node
new_zeropt_nm = model.make_new_valueinfo_name()
Expand All @@ -108,6 +112,8 @@ def apply(self, model: ModelWrapper):
)
graph.value_info.append(out_zeropt)
out_zeropt_node = helper.make_node("Sub", [out_zeropt_nm, zeropt_nm], [final_output])
if hasattr(node, "metadata_props"):
out_zeropt_node.metadata_props.extend(node.metadata_props)
last_node.output[0] = out_zeropt_nm
graph.node.append(out_zeropt_node)
# important: when tracking a pointer to newly added nodes,
Expand All @@ -127,6 +133,8 @@ def apply(self, model: ModelWrapper):
last_node.output[0] = out_scale_nm
graph.value_info.append(out_scale)
out_scale_node = helper.make_node("Mul", [out_scale_nm, scale_nm], [final_output])
if hasattr(node, "metadata_props"):
out_scale_node.metadata_props.extend(node.metadata_props)
graph.node.append(out_scale_node)

if extract_scale or extract_zeropt:
Expand Down
13 changes: 12 additions & 1 deletion src/qonnx/transformation/gemm_to_matmul.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ def apply(self, model):
)
graph.value_info.append(inp_trans_out)
inp_trans_node = helper.make_node("Transpose", [n.input[0]], [inp_trans_out.name])
if hasattr(n, "metadata_props"):
inp_trans_node.metadata_props.extend(n.metadata_props)
graph.node.insert(running_node_index, inp_trans_node)
running_node_index += 1
dt = model.get_tensor_datatype(n.input[0])
Expand All @@ -98,6 +100,8 @@ def apply(self, model):
)
graph.value_info.append(inp_trans_out)
inp_trans_node = helper.make_node("Transpose", [n.input[1]], [inp_trans_out.name])
if hasattr(n, "metadata_props"):
inp_trans_node.metadata_props.extend(n.metadata_props)
graph.node.insert(running_node_index, inp_trans_node)
running_node_index += 1
# Copy over the datatype
Expand All @@ -109,6 +113,8 @@ def apply(self, model):

# Insert MatMul: A * B
matMul_node = helper.make_node("MatMul", [n.input[0], n.input[1]], [n.output[0]])
if hasattr(n, "metadata_props"):
matMul_node.metadata_props.extend(n.metadata_props)
graph.node.insert(running_node_index, matMul_node)
matMul_node = graph.node[running_node_index]
running_node_index += 1
Expand Down Expand Up @@ -144,6 +150,8 @@ def apply(self, model):
[act_mul_tensor.name, mul_tensor.name],
[n.output[0]],
)
if hasattr(n, "metadata_props"):
mul_node.metadata_props.extend(n.metadata_props)
graph.node.insert(running_node_index, mul_node)
mul_node_main_branch = graph.node[running_node_index]
running_node_index += 1
Expand Down Expand Up @@ -175,6 +183,8 @@ def apply(self, model):
[n.input[2], mul_tensor.name],
[act_mul_tensor.name],
)
if hasattr(n, "metadata_props"):
mul_node.metadata_props.extend(n.metadata_props)
graph.node.insert(running_node_index, mul_node)
running_node_index += 1
dt = model.get_tensor_datatype(n.input[2])
Expand All @@ -196,7 +206,8 @@ def apply(self, model):
[act_add_tensor.name, n.input[2]],
[n.output[0]],
)

if hasattr(n, "metadata_props"):
add_node.metadata_props.extend(n.metadata_props)
graph.node.insert(running_node_index, add_node)
running_node_index += 1

Expand Down