-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add support for API 35 EdgeToEdge #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Lyokone
wants to merge
15
commits into
version-9.1.0-dev
Choose a base branch
from
feat/edge-to-edge
base: version-9.1.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6c30641
feat: move from SmartLock to CredentialManager
Lyokone 0b40f22
Start development on v9.0.0 (#2182)
thatfiredev e004565
feat: remove email enumeration (#2184)
Lyokone d154940
feat: add support for API 35 EdgeToEdge
Lyokone 7231cf5
feat: rename setIsSmartLockEnabled to setCredentialManagerEnabled (#2…
Lyokone 8bbd79f
Update all activities
Lyokone 78146a7
Merge branch 'version-9.0.0-dev' into feat/edge-to-edge
Lyokone cb185a2
fix style
Lyokone 2e17c04
remove local settings
Lyokone cdd7394
more padding
Lyokone 877a70c
Merge branch 'version-9.1.0-dev' into feat/edge-to-edge
Lyokone 01a771e
clean
Lyokone a021663
more padding
Lyokone 8ad6004
Merge branch 'version-9.1.0-dev' into feat/edge-to-edge
Lyokone 8daeb88
Update buildSrc/src/main/kotlin/Config.kt
thatfiredev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package com.firebase.uidemo; | ||
|
|
||
| import android.os.Bundle; | ||
| import androidx.annotation.Nullable; | ||
| import androidx.appcompat.app.AppCompatActivity; | ||
| import androidx.core.view.WindowCompat; | ||
|
|
||
| public class BaseActivity extends AppCompatActivity { | ||
| @Override | ||
| protected void onCreate(@Nullable Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); | ||
|
|
||
| // Enable edge-to-edge for all activities | ||
| WindowCompat.setDecorFitsSystemWindows(getWindow(), false); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,67 +1,72 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| <androidx.coordinatorlayout.widget.CoordinatorLayout | ||
| xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| android:id="@+id/root" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:layout_marginLeft="24dp" | ||
| android:layout_marginRight="24dp" | ||
| android:layout_marginTop="16dp" | ||
| android:layout_marginBottom="16dp" | ||
| android:orientation="vertical" | ||
| tools:context=".auth.AuthUiActivity"> | ||
| android:fitsSystemWindows="true"> | ||
|
|
||
| <com.google.android.material.textview.MaterialTextView | ||
| style="@style/TextAppearance.MaterialComponents.Headline5" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center_horizontal" | ||
| android:text="@string/title_anonymous_upgrade" | ||
| app:drawableTopCompat="@drawable/firebase_auth_120dp" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/status_text" | ||
| <LinearLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_margin="16dp" | ||
| android:gravity="center" | ||
| android:textIsSelectable="true" | ||
| tools:text="This is the status view, sometimes it will have a very long status and other..." /> | ||
| android:layout_height="match_parent" | ||
| android:orientation="vertical" | ||
| android:padding="16dp" | ||
| android:clipToPadding="false" | ||
| android:fitsSystemWindows="true"> | ||
|
|
||
| <com.google.android.material.textview.MaterialTextView | ||
| style="@style/TextAppearance.MaterialComponents.Headline5" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center_horizontal" | ||
| android:text="@string/title_anonymous_upgrade" | ||
| app:drawableTopCompat="@drawable/firebase_auth_120dp" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/status_text" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_margin="16dp" | ||
| android:gravity="center" | ||
| android:textIsSelectable="true" | ||
| tools:text="This is the status view, sometimes it will have a very long status and other..." /> | ||
|
|
||
| <Button | ||
| android:id="@+id/anon_sign_in" | ||
| style="@style/Widget.MaterialComponents.Button" | ||
| android:layout_width="200dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:text="@string/anonymous_sign_in" /> | ||
|
|
||
| <Button | ||
| android:id="@+id/anon_sign_in" | ||
| style="@style/Widget.MaterialComponents.Button" | ||
| android:layout_width="200dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:text="@string/anonymous_sign_in" /> | ||
| <Button | ||
| android:id="@+id/begin_flow" | ||
| style="@style/Widget.MaterialComponents.Button" | ||
| android:layout_width="200dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:text="@string/launch_auth_ui" | ||
| android:enabled="false" /> | ||
|
|
||
| <Button | ||
| android:id="@+id/begin_flow" | ||
| style="@style/Widget.MaterialComponents.Button" | ||
| android:layout_width="200dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:text="@string/launch_auth_ui" | ||
| android:enabled="false" /> | ||
| <Button | ||
| android:id="@+id/resolve_merge" | ||
| style="@style/Widget.MaterialComponents.Button" | ||
| android:layout_width="200dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:text="@string/resolve_merge_conflict" | ||
| android:enabled="false" /> | ||
|
|
||
| <Button | ||
| android:id="@+id/resolve_merge" | ||
| style="@style/Widget.MaterialComponents.Button" | ||
| android:layout_width="200dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:text="@string/resolve_merge_conflict" | ||
| android:enabled="false" /> | ||
| <Button | ||
| android:id="@+id/sign_out" | ||
| style="@style/Widget.MaterialComponents.Button" | ||
| android:layout_width="200dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:text="@string/sign_out" | ||
| android:enabled="false" /> | ||
|
|
||
| <Button | ||
| android:id="@+id/sign_out" | ||
| style="@style/Widget.MaterialComponents.Button" | ||
| android:layout_width="200dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_gravity="center" | ||
| android:text="@string/sign_out" | ||
| android:enabled="false" /> | ||
| </LinearLayout> | ||
|
|
||
| </LinearLayout> | ||
| </androidx.coordinatorlayout.widget.CoordinatorLayout> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this is just calling a single method, I'd prefer that we call this method in every other Activity rather than creating this new
BaseActivitythat is extended by all of them.When we migrate the sample app to Kotlin, let's try to get rid of all of these "Base..." classes.