Fix: [Storage] UploadTask should use getMaxUploadRetryTime instead of getMaxDownloadRetryTime #4115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
maneesht
approved these changes
Jan 6, 2023
Replace MaxDownloadRetryTime with MaxUploadRetryTime in UploadTask
enzo-macri
force-pushed
the
emacri-ft-fix-upload-task-retry-time
branch
from
b3659bd to
30f4df1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working in react-native with firebase, I had trouble fine-tuning the MaxRetryTime when uploading file to firebase-storage. At some point, I've noticed that updating the MaxDownloadRetryTime would work. I tracked down the issue from react-native-firebase until here. I try comparing to firebase-ios-sdk and firebase-js-sdk to make sure I am not making a mistake. If that's the case, feel free to just close the PR.