Skip to content

Use lower case M #5141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use lower case M #5141

wants to merge 3 commits into from

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@VinayGuthal VinayGuthal requested a review from daymxn July 6, 2023 17:18
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

buildSrc Test Results

28 tests   28 ✔️  1m 40s ⏱️
  6 suites    0 💤
  6 files      0 ❌

Results for commit b2c80d8.

♻️ This comment has been updated with latest results.

daymxn
daymxn approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023 •
edited
Loading

Unit Test Results

   818 files  +   764     818 suites  +764   37m 10s ⏱️ + 30m 18s
4 956 tests +4 486  4 934 ✔️ +4 464  21 💤 +21  1 ❌ +1 
9 821 runs  +8 881  9 778 ✔️ +8 838  42 💤 +42  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 4055888. ± Comparison against base commit bf8cb54.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (bf8cb54) and merge commit (2f82391).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ysLDrA1UvG.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 6, 2023 •
edited
Loading

Startup Time Report 1

The report is too large (122,614 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HWHnnMGJ8l/index.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.22% (bf8cb54) to 50.14% (2f82391) by -0.08%.

    FilenameBase (bf8cb54)Merge (2f82391)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    QueryParams.java89.76%90.36%+0.60%
    WebsocketConnection.java35.03%32.77%-2.26%

  • firebase-firestore

    Overall coverage changed from 44.35% (bf8cb54) to 44.34% (2f82391) by -0.00%.

    FilenameBase (bf8cb54)Merge (2f82391)Diff
    SetMutation.java97.22%94.44%-2.78%

  • firebase-inappmessaging

    Overall coverage changed from ? (bf8cb54) to 0.00% (2f82391) by ?.

    147 individual files with coverage change

    FilenameBase (bf8cb54)Merge (2f82391)Diff
    AbtIntegrationHelper.java?0.00%?
    AbtIntegrationHelper_Factory.java?0.00%?
    Action.java?0.00%?
    Analytics.java?0.00%?
    AnalyticsConstants.java?0.00%?
    AnalyticsEventsManager.java?0.00%?
    AnalyticsEventsModule.java?0.00%?
    AnalyticsEventsModule_ProvidesAnalyticsConnectorEventsFactory.java?0.00%?
    AnalyticsEventsModule_ProvidesAnalyticsEventsManagerFactory.java?0.00%?
    AnalyticsListener.java?0.00%?
    ApiClient.java?0.00%?
    ApiClientModule.java?0.00%?
    ApiClientModule_ProvidesApiClientFactory.java?0.00%?
    ApiClientModule_ProvidesDataCollectionHelperFactory.java?0.00%?
    ApiClientModule_ProvidesFirebaseAppFactory.java?0.00%?
    ApiClientModule_ProvidesFirebaseInstallationsFactory.java?0.00%?
    ApiClientModule_ProvidesSharedPreferencesUtilsFactory.java?0.00%?
    ApiClientModule_ProvidesTestDeviceHelperFactory.java?0.00%?
    AppComponent.java?0.00%?
    AppForeground.java?0.00%?
    ApplicationModule.java?0.00%?
    ApplicationModule_DeveloperListenerManagerFactory.java?0.00%?
    ApplicationModule_ProvidesApplicationFactory.java?0.00%?
    AppMeasurementModule.java?0.00%?
    AppMeasurementModule_ProvidesAnalyticsConnectorFactory.java?0.00%?
    AppMeasurementModule_ProvidesSubsriberFactory.java?0.00%?
    AutoValue_InstallationIdResult.java?0.00%?
    AutoValue_RateLimit.java?0.00%?
    BannerMessage.java?0.00%?
    Button.java?0.00%?
    CampaignAnalytics.java?0.00%?
    CampaignAnalyticsOrBuilder.java?0.00%?
    CampaignCache.java?0.00%?
    CampaignCacheClient.java?0.00%?
    CampaignCacheClient_Factory.java?0.00%?
    CampaignImpression.java?0.00%?
    CampaignImpressionList.java?0.00%?
    CampaignImpressionListOrBuilder.java?0.00%?
    CampaignImpressionOrBuilder.java?0.00%?
    CampaignMetadata.java?0.00%?
    CampaignProto.java?0.00%?
    CardMessage.java?0.00%?
    ClientAppInfo.java?0.00%?
    ClientAppInfoOrBuilder.java?0.00%?
    Clock.java?0.00%?
    CommonTypesProto.java?0.00%?
    DaggerAppComponent.java?0.00%?
    DaggerUniversalComponent.java?0.00%?
    DataCollectionHelper.java?0.00%?
    DataCollectionHelper_Factory.java?0.00%?
    DeveloperListenerManager.java?0.00%?
    DismissType.java?0.00%?
    DisplayCallbacksFactory.java?0.00%?
    DisplayCallbacksFactory_Factory.java?0.00%?
    DisplayCallbacksImpl.java?0.00%?
    EventType.java?0.00%?
    ExecutorsModule.java?0.00%?
    ExecutorsModule_ProvidesBackgroundExecutorFactory.java?0.00%?
    ExecutorsModule_ProvidesBlockingExecutorFactory.java?0.00%?
    ExecutorsModule_ProvidesLightWeightExecutorFactory.java?0.00%?
    ExperimentPayloadProto.java?0.00%?
    FetchEligibleCampaignsRequest.java?0.00%?
    FetchEligibleCampaignsRequestOrBuilder.java?0.00%?
    FetchEligibleCampaignsResponse.java?0.00%?
    FetchEligibleCampaignsResponseOrBuilder.java?0.00%?
    FetchErrorReason.java?0.00%?
    FiamAnalyticsConnectorListener.java?0.00%?
    FiamFetchService.java?0.00%?
    FirebaseAppScope.java?0.00%?
    FirebaseInAppMessaging.java?0.00%?
    FirebaseInAppMessagingCampaignAnalyticsProto.java?0.00%?
    FirebaseInAppMessagingClickListener.java?0.00%?
    FirebaseInAppMessagingContextualTrigger.java?0.00%?
    FirebaseInAppMessagingDismissListener.java?0.00%?
    FirebaseInAppMessagingDisplay.java?0.00%?
    FirebaseInAppMessagingDisplayCallbacks.java?0.00%?
    FirebaseInAppMessagingDisplayErrorListener.java?0.00%?
    FirebaseInAppMessagingImpressionListener.java?0.00%?
    FirebaseInAppMessagingRegistrar.java?0.00%?
    FirebaseInAppMessaging_Factory.java?0.00%?
    ForegroundFlowableModule.java?0.00%?
    ForegroundFlowableModule_ProvidesAppForegroundEventStreamFactory.java?0.00%?
    ForegroundNotifier.java?0.00%?
    GrpcChannelModule.java?0.00%?
    GrpcChannelModule_ProvidesGrpcChannelFactory.java?0.00%?
    GrpcChannelModule_ProvidesServiceHostFactory.java?0.00%?
    GrpcClient.java?0.00%?
    GrpcClientModule.java?0.00%?
    GrpcClientModule_ProvidesApiKeyHeadersFactory.java?0.00%?
    GrpcClientModule_ProvidesInAppMessagingSdkServingStubFactory.java?0.00%?
    GrpcClient_Factory.java?0.00%?
    ImageData.java?0.00%?
    ImageOnlyMessage.java?0.00%?
    ImpressionStorageClient.java?0.00%?
    ImpressionStorageClient_Factory.java?0.00%?
    ImpressionStore.java?0.00%?
    InAppMessage.java?0.00%?
    InAppMessageStreamManager.java?0.00%?
    InAppMessageStreamManager_Factory.java?0.00%?
    InAppMessagingSdkServingGrpc.java?0.00%?
    InstallationIdResult.java?0.00%?
    Logging.java?0.00%?
    MessagesProto.java?0.00%?
    MessageType.java?0.00%?
    MetricsLoggerClient.java?0.00%?
    ModalMessage.java?0.00%?
    ProgramaticContextualTriggers.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule_ProvidesProgramaticContextualTriggersFactory.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule_ProvidesProgramaticContextualTriggerStreamFactory.java?0.00%?
    ProgrammaticTrigger.java?0.00%?
    ProtoMarshallerClient.java?0.00%?
    ProtoMarshallerClient_Factory.java?0.00%?
    ProtoStorageClient.java?0.00%?
    ProtoStorageClientModule.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForCampaignFactory.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForImpressionStoreFactory.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForLimiterStoreFactory.java?0.00%?
    ProviderInstaller.java?0.00%?
    ProviderInstaller_Factory.java?0.00%?
    ProxyAnalyticsConnector.java?0.00%?
    RateLimit.java?0.00%?
    RateLimiterClient.java?0.00%?
    RateLimiterClient_Factory.java?0.00%?
    RateLimitModule.java?0.00%?
    RateLimitModule_ProvidesAppForegroundRateLimitFactory.java?0.00%?
    RateLimitProto.java?0.00%?
    RenderErrorReason.java?0.00%?
    SchedulerModule.java?0.00%?
    SchedulerModule_ProvidesComputeSchedulerFactory.java?0.00%?
    SchedulerModule_ProvidesIOSchedulerFactory.java?0.00%?
    SchedulerModule_ProvidesMainThreadSchedulerFactory.java?0.00%?
    Schedulers.java?0.00%?
    Schedulers_Factory.java?0.00%?
    SharedPreferencesUtils.java?0.00%?
    SharedPreferencesUtils_Factory.java?0.00%?
    SystemClock.java?0.00%?
    SystemClockModule.java?0.00%?
    SystemClockModule_ProvidesSystemClockModuleFactory.java?0.00%?
    SystemClock_Factory.java?0.00%?
    TestDeviceHelper.java?0.00%?
    TestDeviceHelper_Factory.java?0.00%?
    Text.java?0.00%?
    TransportClientModule.java?0.00%?
    TransportClientModule_ProvidesMetricsLoggerClientFactory.java?0.00%?
    TriggeredInAppMessage.java?0.00%?
    UniversalComponent.java?0.00%?

  • firebase-installations

    Overall coverage changed from ? (bf8cb54) to 58.61% (2f82391) by ?.

    22 individual files with coverage change

    FilenameBase (bf8cb54)Merge (2f82391)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-storage

    Overall coverage changed from ? (bf8cb54) to 85.73% (2f82391) by ?.

    46 individual files with coverage change

    FilenameBase (bf8cb54)Merge (2f82391)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?86.60%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    StorageException.java?65.45%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.38%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.41%?
    TaskListenerImpl.java?100.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.52%?
    Util.java?73.24%?

  • firebase-messaging

    FilenameBase (bf8cb54)Merge (2f82391)Diff
    FirebaseMessaging.java73.13%73.57%+0.44%
    MessagingAnalytics.java81.78%81.38%-0.40%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OCMMf9D9Bd.html

@rlazo
Copy link
Collaborator

rlazo commented Jul 10, 2023

Frindly ping. Is there anything pending to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daymxn daymxn

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VinayGuthal @google-oss-bot @rlazo @daymxn