-
Notifications
You must be signed in to change notification settings - Fork 602
Refactor: Rename encodeBitmapToBase64Png to encodeBitmapToBase64Jpeg #6905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The private function `encodeBitmapToBase64Png` in `firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/Part.kt` was already compressing Bitmap images to JPEG format, not PNG. This commit renames the function to `encodeBitmapToBase64Jpeg` to accurately reflect its behavior. The single call site within the same file has also been updated.
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (534cc53) and merge commit (9915e09).Test Logs |
Test Results 18 files - 48 18 suites - 48 14s ⏱️ - 1m 5s Results for commit c438b82. ± Comparison against base commit 534cc53. This pull request removes 552 and adds 86 tests. Note that renamed tests count towards both.
|
The private function
encodeBitmapToBase64Png
infirebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/Part.kt
was already compressing Bitmap images to JPEG format, not PNG.This commit renames the function to
encodeBitmapToBase64Jpeg
to accurately reflect its behavior. The single call site within the same file has also been updated.no-changelog