Skip to content

Added Proxy Configuration #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

abhinavs1920
Copy link
Contributor

PR Description

This pull request implements a feature that allows users to configure and use a proxy for their HTTP requests within the API Dash application. The feature includes a user interface for inputting proxy settings, storing these settings, and applying them to HTTP requests made using the http package in Flutter.

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I am using the latest Flutter stable branch (run flutter upgrade and verify)
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

  • Yes
  • No, and this is why:

image

I have tested the proxy feature by running a squid proxy server in Python. Above I have attached the image proving that the proxy is working perfectly fine.

OS on which you have developed and tested the feature?

  • Windows
  • macOS
  • Linux

@abhinavs1920 abhinavs1920 changed the title Proxy Added Proxy Configuration Jan 22, 2025
@@ -50,6 +51,75 @@ class SettingsPage extends ConsumerWidget {
ref.read(settingsProvider.notifier).update(isDark: value);
},
),
// Proxy Settings Section
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proxy settings should have its own modal dialog and model.

@ashitaprasad
Copy link
Member

Apart from the above comments, testing is also missing.

@abhinavs1920
Copy link
Contributor Author

@ashitaprasad
I will make the required changes to make it cleaner, simpler, and optimized.

I have a question

  1. Should I create the ProxyModel in packages\apidash_core\lib\models?

@ashitaprasad
Copy link
Member

@ashitaprasad I will make the required changes to make it cleaner, simpler, and optimized.

I have a question

  1. Should I create the ProxyModel in packages\apidash_core\lib\models?

Yes as it is being used by core service (sending http request)

@abhinavs1920
Copy link
Contributor Author

@ashitaprasad
I have completed all the changes required.
I have also added tests for the feature.

image

@abhinavs1920
Copy link
Contributor Author

Hi @ashitaprasad, is there any update regarding this PR.

@ashitaprasad
Copy link
Member

@abhinavs1920 It is under review.

@abhinavs1920 abhinavs1920 force-pushed the proxy branch 2 times, most recently from 57e6947 to 23816ee Compare March 24, 2025 07:49
@abhinavs1920
Copy link
Contributor Author

@ashitaprasad

Please review the changes I have made to address the issues you mentioned.

I accidentally force-pushed my commits, which resulted in overwriting your changes. To correct this, I reverted to your last commit and then reapplied my changes on top of it. Let me know if any further modifications are needed.

@abhinavs1920
Copy link
Contributor Author

@ashitaprasad

Please review the changes I have made to address the issues you mentioned.

I accidentally force-pushed my commits, which resulted in overwriting your changes. To correct this, I reverted to your last commit and then reapplied my changes on top of it. Let me know if any further modifications are needed.

@ashitaprasad Any update?
Thanks!

@abhinavs1920
Copy link
Contributor Author

@ashitaprasad
Please look at the implementation after the updates I did.
Let me know if the approach is fine.

I'll update the branch and resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I want to add a port proxy
2 participants