Make PostgreSQL and Redis connection strings configurable #627
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
imanimen
force-pushed
the
iman-dev/issues_#563
branch
from
88e63a9 to
a1838c0
Compare
imanimen
force-pushed
the
iman-dev/issues_#563
branch
from
a1838c0 to
686b551
Compare
mostafa
changed the title
| @@ -65,6 +75,8 @@ services: | |||
| # https://docs.gatewayd.io/using-gatewayd/configuration#environment-variables | |||
| - GATEWAYD_CLIENTS_DEFAULT_WRITES_ADDRESS=write-postgres:5432 | |||
| - GATEWAYD_CLIENTS_DEFAULT_READS_ADDRESS=read-postgres:5432 | |||
| # Use the connection string set in install_plugins | |||
| - POSTGRES_URL=${POSTGRES_URL} | |||
There was a problem hiding this comment.
This is not used anywhere in the setup.sh script or config files and seems unnecessary.
| # Allow custom PostgreSQL connection string | ||
| - POSTGRES_USER=postgres | ||
| - POSTGRES_PASSWORD=postgres | ||
| - POSTGRES_DB=postgres | ||
| - POSTGRES_URL=postgresql://${POSTGRES_USER}:${POSTGRES_PASSWORD}@write-postgres:5432/${POSTGRES_DB} |
There was a problem hiding this comment.
Unnecessary. Explained why below.
| @@ -72,7 +72,7 @@ plugins: | |||
| env: | |||
| - MAGIC_COOKIE_KEY=GATEWAYD_PLUGIN | |||
| - MAGIC_COOKIE_VALUE=5712b87aa5d7e9f9e9ab643e6603181c5b796015cb1c09d6f5ada882bf2a1872 | |||
| - REDIS_URL=redis://localhost:6379/0 | |||
| - REDIS_URL=${REDIS_URL} # Use environment variable for Redis URL | |||
There was a problem hiding this comment.
Changing these will make this file unusable if someone tries to use it outside Docker and docker-compose. Hence, you should change the setup.sh script to update this instead of changing these files directly. Also, the PostgreSQL addresses and ports are already configurable via environment variables, hence you don't need to change that.
| @@ -43,7 +43,7 @@ actionRedis: | |||
| enabled: false | |||
|
|
|||
| # if enabled, the url and channel are used to connect to the Redis server. | |||
| address: localhost:6379 | |||
| address: ${REDIS_URL} # Use environment variable for Redis URL | |||
There was a problem hiding this comment.
Change this to the following, so that it gets replaced by the value of the REDIS_URL environment variable, defined here:
| address: ${REDIS_URL} # Use environment variable for Redis URL | |
| address: redis://localhost:6379/0 |
There was a problem hiding this comment.
PR Overview
This PR makes PostgreSQL and Redis connection strings configurable via environment variables.
- Updated docker-compose.yaml to introduce environment variables for PostgreSQL connection details and reference these in service configurations.
- Modified gatewayd_plugins.yaml to use the environment variable for the Redis URL.
Reviewed Changes
| File | Description |
|---|---|
| docker-compose.yaml | Introduces POSTGRES_* variables and updates connection string configuration for the gatewayd service. |
| gatewayd_plugins.yaml | Updates the Redis URL to be configurable via an environment variable. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Ticket(s)
Closes #563
Description
Configured the
docker-compose.yaml,gatewayd_plugins.yamlto read from the the Environment variables for redis and postresql url stringRelated PRs
N/A
Development Checklist
make gen-docscommand.Legal Checklist