Skip to content

typescript: Enable strictNullChecks #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: v7
Choose a base branch
from
Draft

Conversation

krystofwoldrich
Copy link
Member

These are enabled in JS Core since the last major v8.

Let's enable them in RN as well.

This PR should not introduce any behavior changes, only fix the null checks.

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Enable strictNullChecks ([#4760](https://github.com/getsentry/sentry-react-native/pull/4760))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 3f3a70b

@krystofwoldrich krystofwoldrich marked this pull request as draft April 16, 2025 18:00
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 419.04 ms 423.62 ms 4.58 ms
Size 17.75 MiB 19.54 MiB 1.79 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9da5c4e 478.08 ms 467.46 ms -10.63 ms
9fbcfaf 420.06 ms 435.31 ms 15.25 ms

App size

Revision Plain With Sentry Diff
9da5c4e 17.75 MiB 20.16 MiB 2.41 MiB
9fbcfaf 17.75 MiB 19.54 MiB 1.79 MiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.92 ms 403.75 ms 4.83 ms
Size 7.15 MiB 8.29 MiB 1.14 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 417.92 ms 431.81 ms 13.90 ms
9da5c4e+dirty 399.70 ms 407.34 ms 7.64 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 7.15 MiB 8.29 MiB 1.14 MiB
9da5c4e+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.24 ms 1216.37 ms -0.88 ms
Size 3.19 MiB 4.34 MiB 1.15 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 1215.22 ms 1222.26 ms 7.04 ms
9da5c4e+dirty 1215.41 ms 1226.38 ms 10.97 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 3.19 MiB 4.34 MiB 1.15 MiB
9da5c4e+dirty 3.19 MiB 4.33 MiB 1.14 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.60 ms 1236.98 ms 13.38 ms
Size 2.63 MiB 3.77 MiB 1.14 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 1216.66 ms 1212.06 ms -4.60 ms
9da5c4e+dirty 1231.84 ms 1235.49 ms 3.65 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 2.63 MiB 3.77 MiB 1.14 MiB
9da5c4e+dirty 2.63 MiB 3.76 MiB 1.13 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant