ref(feedback): add tooltip when delete is disabled #89773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellewzhang
commented
Apr 16, 2025
| @@ -43,7 +43,6 @@ export default function useFeedbackActions({feedbackItem}: Props) { | |||
| projectIds: feedbackItem.project ? [feedbackItem.project.id] : [], | |||
| }); | |||
| const onDelete = useDeleteFeedback([feedbackItem.id], projectId); | |||
| const hasDelete = organization.features.includes('issue-platform-deletion-ui'); | |||
There was a problem hiding this comment.
this flag is rolled out to GA.
There was a problem hiding this comment.
github-actions
bot
added
the
Scope: Frontend
ryan953
approved these changes
Apr 16, 2025
ryan953
reviewed
Apr 16, 2025
| @@ -184,9 +187,11 @@ function SmallWidth({feedbackItem}: {feedbackItem: FeedbackIssue}) { | |||
| key: 'delete', | |||
| priority: 'danger' as const, | |||
| label: t('Delete'), | |||
| hidden: !hasDelete, | |||
There was a problem hiding this comment.
hidden? i should use this more...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #87018
the feedback delete button is disabled if event admin access does not exist. add a tooltip explaining why when it's disabled
large view:
medium view:
small view:
bulk: