fix: set default environment to production only if environment is None #90323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry-autofix[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
github-actions
bot
added
the
Scope: Backend
michellewzhang
added
the
Trigger: getsentry tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi there! This PR was automatically generated by Autofix 🤖
Fixes SENTRY-3SWF. The issue was that:
event_data.get()returnedNonewhen the 'environment' key existed with aNonevalue, causingEnvironment.objects.get(name=None)to fail.The environment was being defaulted to production even if the environment was an empty string. This change ensures that the environment is only defaulted to production if the environment is None.
If you have any questions or feedback for the Sentry team about this fix, please email autofix@sentry.io with the Run ID: 32163.