Skip to content

fix(issue summary): Add locking mechanism #90347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roaga
Copy link
Member

@roaga roaga commented Apr 24, 2025

If a summary is in progress for an issue while another request comes in, the other request should wait for a bit first. This ensures only one call to Seer per issue at a time.

@roaga roaga requested a review from jennmueng April 24, 2025 22:24
@roaga roaga requested a review from a team as a code owner April 24, 2025 22:24
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 24, 2025
Copy link

codecov bot commented Apr 24, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
25296 1 25295 306
View the top 1 failed test(s) by shortest run time
tests.sentry.seer.test_issue_summary.IssueSummaryTest::test_get_issue_summary_concurrent_wait_for_lock
Stack Traces | 3.68s run time
#x1B[1m#x1B[.../sentry/seer/test_issue_summary.py#x1B[0m:453: in test_get_issue_summary_concurrent_wait_for_lock
    assert 1 in results
#x1B[1m#x1B[31mE   assert 1 in {}#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant