feat(taskworker) Add usage_accountant to taskworkers #90424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With taskworkers, worker pools may handle a variety of app_features but we want visibility into the resources used by each feature. The `app_feature` assignments on each namespace are derived from the current celery worker pool assignments in getsentry/ops. If I wasn't able to find a clean mapping `shared` has been used. Refs getsentry/taskbroker#143
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90424 +/- ##
===========================================
+ Coverage 65.59% 87.73% +22.13%
===========================================
Files 10256 10280 +24
Lines 579849 580360 +511
Branches 22617 22637 +20
===========================================
+ Hits 380336 509159 +128823
+ Misses 199070 70774 -128296
+ Partials 443 427 -16 |
evanh
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With taskworkers, worker pools may handle a variety of app_features but we want visibility into the resources used by each feature.
The
app_featureassignments on each namespace are derived from the current celery worker pool assignments in getsentry/ops. If I wasn't able to find a clean mappingsharedhas been used.Refs getsentry/taskbroker#143