ref(uptime): Read uptime_status from uptime_subscription #90434
+20
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-uptime-read-uptime-status-from-uptime-subscription
branch
from
f1950d2 to
c143d74
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90434 +/- ##
==========================================
+ Coverage 85.37% 87.81% +2.43%
==========================================
Files 10270 10270
Lines 579347 579335 -12
Branches 22634 22633 -1
==========================================
+ Hits 494625 508750 +14125
+ Misses 84287 70150 -14137
Partials 435 435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches reading of
uptime_status(anduptime_status_update_date) tothe
uptime_subscriptionmodel.We'll need this to migrate to reading from detectors (and implementing
the detector handler)