chore(migrations): Switch all uses of RunSQL over to SafeRunSQL, and stop relying on allow_run_sql
#90453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and stop relying on `allow_run_sql` Using `RunSQL` is dangerous, because it doesn't apply statement and timeout locks when it runs. We have `SafeRunSQL` now, so we should rely on that. This removes uses of `RunSQL` in the migrations. I'll remove the code that supports `allow_run_sql` in a follow up
github-actions
bot
added
the
Scope: Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
RunSQLis dangerous, because it doesn't apply statement and timeout locks when it runs. We haveSafeRunSQLnow, so we should rely on that.This removes uses of
RunSQLin the migrations. I'll remove the code that supportsallow_run_sqlin a follow up