Skip to content

chore(pace-185): make user mappings table in bigquery case insensitive #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: alpha
Choose a base branch
from
Open

chore(pace-185): make user mappings table in bigquery case insensitive #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
122323d
chore: make user mappings table in bigquery case insensitive
Feb 27, 2024
54590e0
chore: remove unused lines
Feb 27, 2024
4e1fb75
chore: fix tests
Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/kotlin/com/getstrm/pace/processing_platforms/bigquery/BigQueryViewGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ class BigQueryViewGenerator(
select(DSL.field("userGroup"))
.from(DSL.table(renderName(userGroupsTable!!)))
.where(
DSL.field("userEmail")
.eq(DSL.function("SESSION_USER", Boolean::class.java))
DSL.field("lower(userEmail)")
.eq(DSL.lower(DSL.function("SESSION_USER", String::class.java)))
)
)
return jooq.with(userGroupSelect).select(fields)
Expand Down
6 changes: 3 additions & 3 deletions ...c/test/kotlin/com/getstrm/pace/processing_platforms/bigquery/BigQueryViewGeneratorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ with
user_groups as (
select userGroup
from `my_project.my_dataset.my_user_groups`
where userEmail = SESSION_USER()
where lower(userEmail) = lower(SESSION_USER())
)
select
`transactionId`,
Expand Down Expand Up @@ -232,7 +232,7 @@ with
user_groups as (
select userGroup
from `my_project.my_dataset.my_user_groups`
where userEmail = SESSION_USER()
where lower(userEmail) = lower(SESSION_USER())
)
select
case
Expand Down Expand Up @@ -270,7 +270,7 @@ with
user_groups as (
select userGroup
from `my_project.my_dataset.my_user_groups`
where userEmail = SESSION_USER()
where lower(userEmail) = lower(SESSION_USER())
)
select
case
Expand Down