Remove unsafe acceleration structure build #7513
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Builds on #7303 by removing the unsafe acceleration structure build. This function was did not follow what most other underlying API functions were doing, and only removed a single CPU -> GPU copy (which the hal API still allows you to do). This allows lots of API simplifications as well as making it easier to maintain. The simplifications remove things that confused me when I began using this API that were not previously possible before removing the unsafe build. This is a fairly large API change (and a breaking change) for ray tracing, so feel free to comment on the updated design.
Testing
This doesn't add functionality, it just removes things.
Squash or Rebase?
Squash
Checklist
cargo fmt
.cargo clippy --tests
.cargo xtask test
to run tests.CHANGELOG.md
entry.