Skip to content

Remove unsafe acceleration structure build #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

Vecvec
Copy link
Collaborator

@Vecvec Vecvec commented Apr 10, 2025

Connections

Description
Builds on #7303 by removing the unsafe acceleration structure build. This function was did not follow what most other underlying API functions were doing, and only removed a single CPU -> GPU copy (which the hal API still allows you to do). This allows lots of API simplifications as well as making it easier to maintain. The simplifications remove things that confused me when I began using this API that were not previously possible before removing the unsafe build. This is a fairly large API change (and a breaking change) for ray tracing, so feel free to comment on the updated design.

Testing
This doesn't add functionality, it just removes things.

Squash or Rebase?
Squash

Checklist

  • Run cargo fmt.
  • Run cargo clippy --tests.
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@Vecvec Vecvec requested a review from a team as a code owner April 10, 2025 22:00
@Vecvec Vecvec force-pushed the remove-unsafe-acceleration-struct-build branch 2 times, most recently from e62dd7c to 684fd27 Compare April 11, 2025 04:50
@Vecvec Vecvec force-pushed the remove-unsafe-acceleration-struct-build branch from 684fd27 to 9cfa6f4 Compare April 15, 2025 22:32
@cwfitzgerald cwfitzgerald self-assigned this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants