Add dcomp on windows #7550
Open
Add dcomp on windows #7550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Apr 16, 2025
| VisualFromWndHandle { | ||
| handle: Foundation::HWND, | ||
| dcomp_state: RwLock<Option<DCompState>>, | ||
| }, | ||
| Visual(DirectComposition::IDCompositionVisual), |
There was a problem hiding this comment.
Should we be combining these enums?
There was a problem hiding this comment.
honestly i dont know enough about it to say. i think what maybe would make sense is to have a Visual Enum one variant that just has Dcomp Visual and one that has the handle and other state needed
|
will get to this in the next day or two |
…-hunter/wgpu into dev/windows-os-transparent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#3486
#7108
#5150
Description
This adds dcomp support to the dx12 backend.
My main goal for this was to get window transparency to work on windows
Testing
Tested using a basic wgpu app with transparency
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.I dont know if its normal or not but when running
cargo xtask testi had 201 tests fail withcode 0xc0000005: Invalid access to memory location. (os error 998)this is run on windows 10