github · lcartey · Feb 10, 2025 · Feb 6, 2025 · Feb 6, 2025 · Feb 8, 2025
diff --git a/change_notes/2025-02-06-a3-1-5-audit.md b/change_notes/2025-02-06-a3-1-5-audit.md
@@ -0,0 +1,2 @@
+ - `A3-1-5` - `NonTrivalNonTemplateFunctionDefinedInsideClassDefinition.ql`:
+   - Mark this as an `audit` query. As a consequence, it will no longer be run as part of the default query suite for AUTOSAR. It can still be run as part of the `autosar-audit.qls` query suite. The query has been downgraded because the rule allows for functions to be declared in the class body if they were "intended" to be inlined, and that developer intention cannot be determined automatically from the code.
diff --git a/cpp/autosar/src/rules/A3-1-5/NonTrivialNonTemplateFunctionDefinedInsideClassDefinition.ql b/cpp/autosar/src/rules/A3-1-5/NonTrivialNonTemplateFunctionDefinedInsideClassDefinition.ql
@@ -7,6 +7,7 @@
  * @precision very-high
  * @problem.severity recommendation
  * @tags external/autosar/id/a3-1-5
+ *       external/autosar/audit
  *       external/autosar/allocated-target/design
  *       external/autosar/enforcement/partially-automated
  *       external/autosar/obligation/required

diff --git a/rule_packages/cpp/Classes.json b/rule_packages/cpp/Classes.json
@@ -185,7 +185,9 @@
           "precision": "very-high",
           "severity": "recommendation",
           "short_name": "NonTrivialNonTemplateFunctionDefinedInsideClassDefinition",
-          "tags": []
+          "tags": [
+            "external/autosar/audit"
+          ]
         }
       ],
       "title": "A function definition shall only be placed in a class definition if (1) the function is intended to be inlined (2) it is a member function template (3) it is a member function of a class template."
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		- `A3-1-5` - `NonTrivalNonTemplateFunctionDefinedInsideClassDefinition.ql`:
lcartey marked this conversation as resolved. Show resolved Hide resolved
		- Mark this as an `audit` query. As a consequence, it will no longer be run as part of the default query suite for AUTOSAR. It can still be run as part of the `autosar-audit.qls` query suite. The query has been downgraded because the rule allows for functions to be declared in the class body if they were "intended" to be inlined, and that developer intention cannot be determined automatically from the code.