Skip to content

Misc: Add script to accept .expected changes from CI #12977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented May 1, 2023

This script can be used to go over codeql test run expected/actual log
output from actions CI checks for a PR, and apply patches locally to
make the tests pass.

Designed for use by GitHub employees, since it needs access to internal CI runs. Just run this tool while the branch for the PR is checked out!

You need the gh cli tool installed and authenticated.

Example can be seen in #12950

This script can be used to go over `codeql test run` expected/actual log
output from actions CI checks for a PR, and apply patches locally to
make the tests pass.

Designed for use by GitHub employees, since it needs access to internal
CI runs. Just run this tool while the branch for the PR is checked out!

You need the `gh` cli tool installed and authenticated.

Example can be seen in github#12950
@MathiasVP
Copy link
Contributor

I haven't reviewed any of the code, but this totally did the Right Thing for the .expected files in #12959 🎉

Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't studied the code in detail, but it has done the right thing on all the PRs I've tried. So this LGTM!

@MathiasVP MathiasVP merged commit f1530aa into github:main May 17, 2023
@RasmusWL RasmusWL deleted the accept-expected-changes-from-ci-script branch June 7, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants