Skip to content

Dataflow perf investigations #15444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Dataflow perf investigations #15444

wants to merge 19 commits into from
+1,277 −414

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jan 26, 2024

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 26, 2024
View reviewed changes
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
}

pragma[nomagic]
private predicate isExactArgument(ArgumentNode arg, BasicBlock bb, Method m, ArgumentPosition apos) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
}

pragma[nomagic]
private predicate setsInstanceField(Field f, Node qualifier, BasicBlock bb) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
}

pragma[nomagic]
private predicate isInstanceFieldSetter(Method m, ArgumentPosition apos, Field f) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
)
}

private predicate sdf(Field f, Class c) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
)
}

/** A debug predicate for identifying the most busy node in forwards flow. */

Check warning

Code scanning / CodeQL

Predicate QLDoc style.

The QLDoc for a predicate without a result should start with 'Holds'.
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
)
}

/** A debug predicate for identifying the most busy node in reverse flow. */

Check warning

Code scanning / CodeQL

Predicate QLDoc style.

The QLDoc for a predicate without a result should start with 'Holds'.
@hvitved hvitved force-pushed the dataflow-perf-investigations branch from b4b45d6 to 069406e Compare January 30, 2024 10:55
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 30, 2024
View reviewed changes
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
/**
* Holds if forward flow with access path `tail` and type `t1` reaches a
* store of `c` on a container of type `t2` resulting in access path
* `cons`.
*/
pragma[nomagic]
private predicate fwdFlowConsCand(Typ t2, Ap cons, Content c, Typ t1, Ap tail) {
fwdFlowStore(_, t1, tail, c, t2, _, _, _, _, _, _) and
private predicate fwdFlowConsCandNoStrenght(

Check warning

Code scanning / CodeQL

Misspelling

This predicate name contains the common misspelling 'strenght', which should instead be 'strength'.
@hvitved hvitved force-pushed the dataflow-perf-investigations branch from 73da939 to 147f854 Compare February 8, 2024 16:22
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 8, 2024
View reviewed changes
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
pragma[nomagic]
additional predicate nodeMayFlowThrough(ParamNode p, Ap argAp, NodeEx node, Ap ap) {
// revFlow(node, _, TReturnCtxMaybeFlowThrough(_), _, ap)
exists(ApOption argApO, ReturnPosition pos, Ap returnAp, ApOption returnApO |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable

This exists variable can be omitted by using a don't-care expression [in this argument](1).
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll
@@ -33,6 +33,11 @@
result.asSummarizedCallable().getACall() = c.asCall()
}

private DataFlowCallable viableCallable(DataFlowCall c, int k) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll
@@ -122,6 +127,26 @@
mayBenefitFromCallContext(call.asCall(), _, _)
}

private DataFlowCallable testviableImplInCallContext(DataFlowCall call, DataFlowCall ctx) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll
}

pragma[nomagic]
private predicate foo(DataFlowCall call, DataFlowCall ctx1, DataFlowCall ctx2) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll
)
}

private DataFlowCallable testviableImplInCallContext(

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
@@ -365,6 +408,12 @@
erasedHaveIntersection(t1, t2)
}

private predicate sdef(DataFlowType t1, DataFlowType t2) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
@hvitved hvitved force-pushed the dataflow-perf-investigations branch from 147f854 to f8347e9 Compare February 21, 2024 12:39
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 21, 2024
View reviewed changes
java/ql/lib/semmle/code/java/security/TaintedPathQuery.qll
sanitizer instanceof PathInjectionSanitizer
sanitizer instanceof PathInjectionSanitizer or
sanitizer.getLocation().getFile().getBaseName() =
[/*"BaseObject.java", "SimpleNode.java",*/ "Context.java"]

Check warning

Code scanning / CodeQL

Singleton set literal

Singleton set literal can be replaced by its member.
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll
@@ -33,6 +33,16 @@
result.asSummarizedCallable().getACall() = c.asCall()
}

private DataFlowCallable testviableCallable(DataFlowCall c) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
private module Stage3 = MkStage<Stage2_5>::Stage<Stage3Param>;

// private predicate mostBusyNodeFwd3 = Stage3::mostBusyNodeFwd/10;
private predicate mostBusyNodeFwd3_5 = Stage3_5::mostBusyNodeFwd/10;

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
private predicate mostBusyNodeFwd3_5 = Stage3_5::mostBusyNodeFwd/10;

// private predicate mostBusyNodeFwd4 = Stage4::mostBusyNodeFwd/10;
private predicate mostBusyNodeFwd5 = Stage5::mostBusyNodeFwd/10;

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
ArgTyp argT, Ap argAp, ApApprox argApa, Typ t, TypOption origT, Ap ap, ApApprox apa,
boolean allowsFieldFlow
) {
exists(DataFlowCall call, RetNodeEx ret |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable

This exists variable can be omitted by using a don't-care expression [in this argument](1).
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
) {
exists(ReturnKindExt kind |
exists(DataFlowCall call, ReturnKindExt kind |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable

This exists variable can be omitted by using a don't-care expression [in this argument](1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C# C++ DataFlow Library Go Java Python Ruby Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hvitved