Code

Go/feature/shared ssa library#19011

Code

Draft

owen-mc wants to merge 24 commits intogithub:maingithub/codeql:mainfrom

owen-mc:go/feature/shared-ssa-libraryowen-mc/codeql:go/feature/shared-ssa-libraryCopy head branch name to clipboard

Commits

Commits on Mar 6, 2025

• Switch to use-use dataflow. This will make post-update nodes easy to implement.

  Show description for 8d844e8
  owen-mc

  committed
  8d844e8

  Copy full SHA for 8d844e8

• Add missing QLDoc

  owen-mc

  committed
  06404d8

  Copy full SHA for 06404d8

• Clean up code in basicLocalFlowStep

  Show description for d8002a0
  owen-mc

  committed
  d8002a0

  Copy full SHA for d8002a0

• Include first step from SsaVariableCapture

  Show description for 1904daf
  owen-mc

  committed
  1904daf

  Copy full SHA for 1904daf

• Adjust SafeFormatArgumentSanitizer to use-use flow

  Show description for 9d88795
  owen-mc

  committed
  9d88795

  Copy full SHA for 9d88795

• Test result that was missing is now found

  owen-mc

  committed
  f67555a

  Copy full SHA for f67555a

• Expected changes in dataflow edges

  owen-mc

  committed
  03204cf

  Copy full SHA for 03204cf

• f extra edge

  owen-mc

  committed
  487dba3

  Copy full SHA for 487dba3

• Line numbers change because 3 lines were added

  owen-mc

  committed
  c040c9a

  Copy full SHA for c040c9a

• Changes in edges in .expected files

  owen-mc

  committed
  8b6a173

  Copy full SHA for 8b6a173

• Extra edge to captured variable

  owen-mc

  committed
  ef9f740

  Copy full SHA for ef9f740

• Fix Allocation Size Overflow for use-use flow

  Show description for ad0b836
  owen-mc

  committed
  ad0b836

  Copy full SHA for ad0b836

• Expected test changes (odd because post update nodes are still at the def)

  owen-mc

  committed
  68128b3

  Copy full SHA for 68128b3

• Optimise join order for varBlockReaches

  

  smowton

  authored and

  owen-mc

  committed
  818ebea

  Copy full SHA for 818ebea

• Fix IncorrectIntegerConversion for use-use flow

  Show description for 6c863c6
  owen-mc

  committed
  6c863c6

  Copy full SHA for 6c863c6

• accept edge changes

  owen-mc

  committed
  5a09b15

  Copy full SHA for 5a09b15

• Accept fixed test result

  owen-mc

  committed
  7f5e973

  Copy full SHA for 7f5e973

• Make insecure randomness test more realistic

  owen-mc

  committed
  c308978

  Copy full SHA for c308978

Commits on Mar 7, 2025

• Fix TypeAssertionCheck to not block successor flow

  Show description for a3dbc5e
  owen-mc

  committed
  a3dbc5e

  Copy full SHA for a3dbc5e

Commits on Mar 13, 2025

• Improve SSA tests for variables in closures

  owen-mc

  committed
  635b722

  Copy full SHA for 635b722

• Invoke `SsaImplCommon::Make`

  owen-mc

  committed
  a15ab99

  Copy full SHA for a15ab99

• Refactor: reorder parameters of `SsaDefinition.definesAt`

  Show description for 5bc4ccf
  owen-mc

  committed
  5bc4ccf

  Copy full SHA for 5bc4ccf

Commits on Mar 15, 2025

• Base SSA classes on shared SSA library

  owen-mc

  committed
  521b971

  Copy full SHA for 521b971

• Test changes

  owen-mc

  committed
  d49f05f

  Copy full SHA for d49f05f