-
Notifications
You must be signed in to change notification settings - Fork 1.7k
JS: Fix missing flow into rest pattern lvalue #19283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asgerf
wants to merge
3
commits into
github:main
Choose a base branch
from
asgerf:js/rest-pattern-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
javascript/ql/test/library-tests/GetALocalSource/rest-pattern.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| function t1() { | ||
| const { ...rest } = source('t1.1'); | ||
| rest; // $ getALocalSource=rest | ||
| } | ||
|
|
||
| function t2() { | ||
| const [ ...rest ] = source('t2.1'); | ||
| rest; // $ getALocalSource=rest | ||
| } | ||
|
|
||
| function t3() { | ||
| const { p1, ...rest } = source('t3.1'); | ||
| p1; // $ getALocalSource=p1 | ||
| rest; // $ getALocalSource=rest | ||
| } |
4 changes: 4 additions & 0 deletions
4
javascript/ql/test/library-tests/GetALocalSource/test.expected
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| | rest-pattern.js:3:5:3:8 | rest | rest | | ||
| | rest-pattern.js:8:5:8:8 | rest | rest | | ||
| | rest-pattern.js:13:5:13:6 | p1 | p1 | | ||
| | rest-pattern.js:14:5:14:8 | rest | rest | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import javascript | ||
|
|
||
| string nodeName(DataFlow::SourceNode node) { | ||
| result = node.getAstNode().(VarRef).getName() | ||
| or | ||
| result = node.getAstNode().(PropertyPattern).getName() | ||
| or | ||
| result = node.getAstNode().(PropAccess).getPropertyName() | ||
| or | ||
| exists(DataFlow::InvokeNode invoke | | ||
| node = invoke and | ||
| invoke.getCalleeName() = "source" and | ||
| result = invoke.getArgument(0).getStringValue() | ||
| ) | ||
| } | ||
|
|
||
| bindingset[node1, node2] | ||
| pragma[inline_late] | ||
| predicate sameLine(DataFlow::Node node1, DataFlow::Node node2) { | ||
| node1.getLocation().getFile() = node2.getLocation().getFile() and | ||
| node1.getLocation().getStartLine() = node2.getLocation().getStartLine() | ||
| } | ||
|
|
||
| query predicate getALocalSource(DataFlow::Node node, string name) { | ||
| exists(DataFlow::SourceNode sn | | ||
| sn = node.getALocalSource() and | ||
| name = nodeName(sn) and | ||
| not sameLine(node, sn) | ||
| ) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| query: test.ql | ||
| postprocess: utils/test/InlineExpectationsTestQuery.ql |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Predicates starting with "get" or "as" should return a value Warning test