Swift: make extractor compile again after 6.1 upgrade #19315
+29
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsun82
force-pushed
the
redsun82/swift-6.1
branch
from
cc07637 to
593c8d8
Compare
jketema
reviewed
Apr 16, 2025
Comment on lines
-356
to
+359
| llvm::SmallVector<char> uuid; | ||
| type->getOpenedExistentialID().toString(uuid); | ||
| return visitArchetypeType(type) << std::string_view(uuid.data(), uuid.size()); | ||
| // llvm::SmallVector<char> uuid; | ||
| // type->getOpenedExistentialID().toString(uuid); // <- doesn't compile any more | ||
| // return visitArchetypeType(type) << std::string_view(uuid.data(), uuid.size()); | ||
| return visitArchetypeType(type); |
There was a problem hiding this comment.
Looking at swiftlang/swift#76238 I see the following change:
- printFieldQuoted(T->getOpenedExistentialID(), "opened_existential_id");
+ auto *env = T->getGenericEnvironment();
+ printFieldQuoted(env->getOpenedExistentialUUID(), "opened_existential_id");where T is of type OpenedArchetypeType.
jketema
reviewed
Apr 16, 2025
| auto pattern = expr.getRegexText(); | ||
| auto pattern = expr.getParsedRegexText(); // TODO: there is now this and getRegexToEmit |
There was a problem hiding this comment.
getRegexText was removed in swiftlang/swift#76979.
Looks like the ASTDumper and ASTPrinter have the same replacement as we do here. In SILGenApply it gets replaced with getRegexToEmit. To me following what the dumper and printer do intuitively makes most sense given what we do with the result (put it in a database). Is that a correct observation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.