Skip to content

Rust: Path resolution performance tweaks #19358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Rust: Path resolution performance tweaks #19358

merged 1 commit into from
Apr 25, 2025
+48 −25

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Apr 23, 2025 •
edited
Loading

Example tuple counts:

image

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Apr 23, 2025
@hvitved hvitved force-pushed the rust/path-resolution-perf-tweaks branch from 6d05f5f to e72aba7 Compare April 23, 2025 17:49
@hvitved hvitved marked this pull request as ready for review April 24, 2025 06:47
@Copilot Copilot AI review requested due to automatic review settings April 24, 2025 06:47
@hvitved hvitved requested a review from a team as a code owner April 24, 2025 06:47
Copilot
Copilot AI reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • rust/ql/lib/codeql/rust/internal/PathResolution.qll: Language not supported

@hvitved hvitved requested a review from paldepind April 24, 2025 06:54
@paldepind
Copy link
Contributor

There are some miniscule changes in the rust-analyzer comparison in DCA rust random wiggle? Is that just random noise? Can they wiggle without any actual changes in the QL?

@hvitved
Copy link
Contributor Author

hvitved commented Apr 25, 2025

There are some miniscule changes in the rust-analyzer comparison in DCA rust random wiggle? Is that just random noise? Can they wiggle without any actual changes in the QL?

I believe it happens because extraction is somehow non-deterministic, ideally both runs should just use the same DB (see https://github.com/github/codeql-dca/issues/2530).

@hvitved hvitved merged commit 432435f into github:main Apr 25, 2025
16 checks passed
@hvitved hvitved deleted the rust/path-resolution-perf-tweaks branch April 25, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@paldepind paldepind paldepind approved these changes

Assignees
No one assigned
Labels
Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @paldepind