Skip to content

Python: disable diff-informed PolynomialReDoS.ql #19379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Python: disable diff-informed PolynomialReDoS.ql #19379

merged 1 commit into from
Apr 25, 2025
+11 −1

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Apr 24, 2025

This commit disabled diff-informed for PolynomialReDoS.ql because it could miss some alerts within diff ranges.

@cklin
Python: disable diff-informed PolynomialReDoS.ql
6c1e80d 
This commit disabled diff-informed for PolynomialReDoS.ql because it
could miss some alerts within diff ranges.
@cklin cklin added the no-change-note-required This PR does not need a change note label Apr 24, 2025
@cklin cklin marked this pull request as ready for review April 24, 2025 22:02
@Copilot Copilot AI review requested due to automatic review settings April 24, 2025 22:02
@cklin cklin requested a review from a team as a code owner April 24, 2025 22:02
Copilot
Copilot AI reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • python/ql/lib/semmle/python/security/dataflow/PolynomialReDoSQuery.qll: Language not supported

asgerf
asgerf approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for the detailed explanation.

@cklin cklin merged commit ed69097 into main Apr 25, 2025
18 checks passed
@cklin cklin deleted the cklin/python-polynomial-redos branch April 25, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot

@asgerf asgerf

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cklin @asgerf