feat: extract environment variable handling #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] central env.py for gathering and setting env vars - [x] bool and int env var handling and tests broken out Signed-off-by: jmeridth <jmeridth@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR extracts environment variable handling into a centralized module (env.py) and refactors the code and tests accordingly to support boolean and integer environment variable parsing.
- Moved environment variable handling from multiple files into env.py
- Added dedicated tests for get_int_env_var and get_bool_env_var
- Updated stale_repos.py to use the new env.py module for configuration
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_stale_repos.py | Removed tests for get_int_env_var to avoid redundancy with new tests |
| test_env_get_int.py | Added tests for integer environment variable parsing |
| test_env_get_bool.py | Added tests for boolean environment variable parsing |
| test_env.py | Added tests for overall environment variable gathering logic |
| stale_repos.py | Refactored to use get_env_vars instead of inline dotenv loading |
| env.py | New module to encapsulate environment variable handling and parsing |
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
thanks copilot Signed-off-by: jmeridth <jmeridth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenanceorbreaking