Skip to content

chore: move perms up to workflow level #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 4, 2025

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth self-assigned this Apr 4, 2025
@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 05:06
@jmeridth jmeridth requested a review from a team as a code owner April 4, 2025 05:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves repository permissions up to the workflow level, updating the permission for the "contents" scope from "read" to "write" and removing the redundant job-specific permissions.

  • Updated global permissions from "read" to "write"
  • Removed job-level permissions in the update_tag job
Comments suppressed due to low confidence (1)

.github/workflows/major-version-updater.yml:13

  • Switching the global 'contents' permission to write increases the workflow's privileges; please confirm that this elevated access is intended and does not inadvertently grant more permissions than needed.
contents: write

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@jmeridth jmeridth merged commit f4a5759 into main Apr 4, 2025
10 checks passed
@jmeridth jmeridth deleted the jm_perms_test_again branch April 4, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant